Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 8555020: aura: Fix popup window positioning. (Closed)

Created:
9 years, 1 month ago by sadrul
Modified:
9 years, 1 month ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

aura: Fix popup window positioning. Comboboxes in a web-page show up in the wrong place if the browser window is not positioned at (0,0). BUG=104224 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110000

Patch Set 1 #

Total comments: 6

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
9 years, 1 month ago (2011-11-14 23:32:08 UTC) #1
Ben Goodger (Google)
http://codereview.chromium.org/8555020/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): http://codereview.chromium.org/8555020/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode132 content/browser/renderer_host/render_widget_host_view_aura.cc:132: // |pos| is in desktop coordinate. So convert it ...
9 years, 1 month ago (2011-11-14 23:36:17 UTC) #2
sadrul
http://codereview.chromium.org/8555020/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): http://codereview.chromium.org/8555020/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode132 content/browser/renderer_host/render_widget_host_view_aura.cc:132: // |pos| is in desktop coordinate. So convert it ...
9 years, 1 month ago (2011-11-14 23:42:51 UTC) #3
Ben Goodger (Google)
9 years, 1 month ago (2011-11-14 23:46:06 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698