aura: Fix popup window positioning.

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include "base/logging.h"
 #include "content/browser/renderer_host/backing_store_skia.h"
 #include "content/browser/renderer_host/render_widget_host.h"
 #include "content/browser/renderer_host/web_input_event_aura.h"
@@ skipping 110 matching lines @@
 void RenderWidgetHostViewAura::InitAsPopup(
     RenderWidgetHostView* parent_host_view,
     const gfx::Rect& pos) {
   popup_parent_host_view_ =
       static_cast<RenderWidgetHostViewAura*>(parent_host_view);
   window_->SetType(aura::WINDOW_TYPE_MENU);
   window_->Init(ui::Layer::LAYER_HAS_TEXTURE);
 
   window_->SetParent(NULL);
   Show();
-  SetBounds(pos);
+
+  // |pos| is in desktop coordinate. So convert it to

[Ben Goodger (Google), 2011/11/14 23:36:17]

coordinates

[sadrul, 2011/11/14 23:42:51]

Done.

+  // |popup_parent_host_view_|'s coordinate first.

[Ben Goodger (Google), 2011/11/14 23:36:17]

coordinates

[sadrul, 2011/11/14 23:42:51]

Done.

+  gfx::Point origin = pos.origin();
+  aura::Window::ConvertPointToWindow(
+      static_cast<aura::Window*>(aura::Desktop::GetInstance()),

[Ben Goodger (Google), 2011/11/14 23:36:17]

cast isn't necessary?

[sadrul, 2011/11/14 23:42:51]

Indeed. Removed.

+      popup_parent_host_view_->window_, &origin);
+  SetBounds(gfx::Rect(origin, pos.size()));
 }
 
 void RenderWidgetHostViewAura::InitAsFullscreen(
     RenderWidgetHostView* reference_host_view) {
   is_fullscreen_ = true;
   window_->SetType(aura::WINDOW_TYPE_NORMAL);
   window_->Init(ui::Layer::LAYER_HAS_TEXTURE);
   window_->SetIntProperty(aura::kShowStateKey, ui::SHOW_STATE_FULLSCREEN);
   window_->SetParent(NULL);
   Show();
@@ skipping 392 matching lines @@
 // static
 void RenderWidgetHostView::GetDefaultScreenInfo(
     WebKit::WebScreenInfo* results) {
   const gfx::Size size = gfx::Screen::GetPrimaryMonitorSize();
   results->rect = WebKit::WebRect(0, 0, size.width(), size.height());
   results->availableRect = results->rect;
   // TODO(derat): Don't hardcode this?
   results->depth = 24;
   results->depthPerComponent = 8;
 }