chrome/browser/resources/policy.html - Issue 8555009: Fix display and progressive disclosure for multi-line values in about:policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/policy.html

Issue 8555009: Fix display and progressive disclosure for multi-line values in about:policy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, make hide/show proper links. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/policy.html

diff --git a/chrome/browser/resources/policy.html b/chrome/browser/resources/policy.html

index 8f7349e4b04c7d2626339c6b8f4dd6435dc58311..f8c26c487b85032957d82520bd451b5f7c4c9b8c 100644

--- a/chrome/browser/resources/policy.html

+++ b/chrome/browser/resources/policy.html

@@ -127,24 +127,26 @@

</td>

<td>

- <div class="text-container collapsed">

- <span class="cell-text" jscontent="value"></span>

+ <div class="text-collapsed text-container">

+ <a class="link-button toggler expand" hidden

James Hawkins 2011/11/14 18:12:35 You shouldn't use both <a> and link-button. link-

James Hawkins 2011/11/14 18:12:35 nit: No-value attributes should be last, i.e., hid

Mattias Nissler (ping if slow) 2011/11/14 18:36:17 Ah, didn't know that, makes much more sense this w

Mattias Nissler (ping if slow) 2011/11/14 18:36:17 Done.

+ i18n-content="showMoreText"></a>

+ <div class="text-cell">

+ <span class="text-value" jscontent="value"></span>

+ </div>

+ <a class="link-button toggler collapse" hidden

+ i18n-content="hideText"></a>

</div>

- <a class="toggler expand" style="display: none"

- jsdisplay="Policy.shouldShowExpand(this)"

- i18n-content="showMoreText"></a>

- <a class="toggler collapse" style="display: none"

- i18n-content="hideText"></a>

</td>

<td>

- <div class="text-container collapsed">

- <span class="cell-text" jscontent="status"></span>

+ <div class="text-collapsed text-container">

+ <a class="link-button toggler expand" hidden

+ i18n-content="showMoreText"></a>

+ <div class="text-cell">

+ <span class="text-value" jscontent="status"></span>

+ </div>

+ <a class="link-button toggler collapse" hidden

+ i18n-content="hideText"></a>

</div>

- <a class="toggler expand" style="display: none"

- jsdisplay="Policy.shouldShowExpand(this)"

- i18n-content="showMoreText"></a>

- <a class="toggler collapse" style="display: none"

- i18n-content="hideText"></a>

</td>

</tr>

</table>

« no previous file with comments | « chrome/browser/resources/policy.css ('k') | chrome/browser/resources/policy.js » ('j') | no next file with comments »