Chromium Code Reviews Chromium Code Reviews
Issue 8555009:
Fix display and progressive disclosure for multi-line values in about:policy. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 <!DOCTYPE HTML> | 1 <!DOCTYPE HTML> |
| 2 <html i18n-values="dir:textdirection"> | 2 <html i18n-values="dir:textdirection"> |
| 3 <head> | 3 <head> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <title i18n-content="policyTitle"></title> | 5 <title i18n-content="policyTitle"></title> |
| 6 <link rel="stylesheet" href="chrome://resources/css/button.css"> | 6 <link rel="stylesheet" href="chrome://resources/css/button.css"> |
| 7 <link rel="stylesheet" href="policy.css"> | 7 <link rel="stylesheet" href="policy.css"> |
| 8 <script src="chrome://policy/strings.js"></script> | 8 <script src="chrome://policy/strings.js"></script> |
| 9 <script src="chrome://resources/js/cr.js"></script> | 9 <script src="chrome://resources/js/cr.js"></script> |
| 10 <script src="chrome://resources/js/cr/ui.js"></script> | 10 <script src="chrome://resources/js/cr/ui.js"></script> |
| (...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 120 <span class="policy-type" jscontent="sourceType"></span> | 120 <span class="policy-type" jscontent="sourceType"></span> |
| 121 </td> | 121 </td> |
| 122 --> | 122 --> |
| 123 <td> | 123 <td> |
| 124 <span class="policy-level" jscontent="level"></span> | 124 <span class="policy-level" jscontent="level"></span> |
| 125 </td> | 125 </td> |
| 126 <td class="collapsed"> | 126 <td class="collapsed"> |
| 127 <span class="policy-name" jscontent="name"></span> | 127 <span class="policy-name" jscontent="name"></span> |
| 128 </td> | 128 </td> |
| 129 <td> | 129 <td> |
| 130 <div class="text-container collapsed"> | 130 <div class="text-collapsed text-container"> |
| 131 <span class="cell-text" jscontent="value"></span> | 131 <a class="link-button toggler expand" hidden |
|
James Hawkins
2011/11/14 18:12:35
You shouldn't use both <a> and link-button. link-
James Hawkins
2011/11/14 18:12:35
nit: No-value attributes should be last, i.e., hid
Mattias Nissler (ping if slow)
2011/11/14 18:36:17
Ah, didn't know that, makes much more sense this w
Mattias Nissler (ping if slow)
2011/11/14 18:36:17
Done.
| |
| 132 i18n-content="showMoreText"></a> | |
| 133 <div class="text-cell"> | |
| 134 <span class="text-value" jscontent="value"></span> | |
| 135 </div> | |
| 136 <a class="link-button toggler collapse" hidden | |
| 137 i18n-content="hideText"></a> | |
| 132 </div> | 138 </div> |
| 133 <a class="toggler expand" style="display: none" | |
| 134 jsdisplay="Policy.shouldShowExpand(this)" | |
| 135 i18n-content="showMoreText"></a> | |
| 136 <a class="toggler collapse" style="display: none" | |
| 137 i18n-content="hideText"></a> | |
| 138 </td> | 139 </td> |
| 139 <td> | 140 <td> |
| 140 <div class="text-container collapsed"> | 141 <div class="text-collapsed text-container"> |
| 141 <span class="cell-text" jscontent="status"></span> | 142 <a class="link-button toggler expand" hidden |
| 143 i18n-content="showMoreText"></a> | |
| 144 <div class="text-cell"> | |
| 145 <span class="text-value" jscontent="status"></span> | |
| 146 </div> | |
| 147 <a class="link-button toggler collapse" hidden | |
| 148 i18n-content="hideText"></a> | |
| 142 </div> | 149 </div> |
| 143 <a class="toggler expand" style="display: none" | |
| 144 jsdisplay="Policy.shouldShowExpand(this)" | |
| 145 i18n-content="showMoreText"></a> | |
| 146 <a class="toggler collapse" style="display: none" | |
| 147 i18n-content="hideText"></a> | |
| 148 </td> | 150 </td> |
| 149 </tr> | 151 </tr> |
| 150 </table> | 152 </table> |
| 151 </div> | 153 </div> |
| 152 </div> | 154 </div> |
| 153 </section> | 155 </section> |
| 154 </div> | 156 </div> |
| 155 </div> | 157 </div> |
| 156 </body> | 158 </body> |
| 157 </html> | 159 </html> |
| OLD | NEW |
