Fix display and progressive disclosure for multi-line values in about:policy.

Fix display and progressive disclosure for multi-line values in about:policy.

Previously, all lines were joined together into a single hard-to-read
block. Change expanded state to make white-space significant so
multi-line error messages are on separate lines and network
configuration renders nicely.

BUG=chromium:104138
TEST=Put network configuration policy in place and check about:policy.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110070

[Mattias Nissler (ping if slow), 2011-11-14 16:12:37]

James, can you please review the HTML/CSS?

Joao, just a single chrome/browser/policy line for you :)

[Joao da Silva, 2011-11-14 16:47:02]

policy LGTM

[James Hawkins, 2011-11-14 17:34:47]

http://codereview.chromium.org/8555009/diff/1/chrome/browser/resources/policy...
File chrome/browser/resources/policy.html (right):

http://codereview.chromium.org/8555009/diff/1/chrome/browser/resources/policy...
chrome/browser/resources/policy.html:131: <a class="toggler expand"
style="display: none"
Use hidden instead of syle=display none

http://codereview.chromium.org/8555009/diff/1/chrome/browser/resources/policy...
chrome/browser/resources/policy.html:131: <a class="toggler expand"
style="display: none"
Are these actual links or buttons that look like links?  If the latter, use the
link-button class.

http://codereview.chromium.org/8555009/diff/1/chrome/browser/resources/policy.js
File chrome/browser/resources/policy.js (right):

http://codereview.chromium.org/8555009/diff/1/chrome/browser/resources/policy...
chrome/browser/resources/policy.js:144: 
Remove blank line.

[Mattias Nissler (ping if slow), 2011-11-14 17:59:28]

PTAL. Thanks!

http://codereview.chromium.org/8555009/diff/1/chrome/browser/resources/policy...
File chrome/browser/resources/policy.html (right):

http://codereview.chromium.org/8555009/diff/1/chrome/browser/resources/policy...
chrome/browser/resources/policy.html:131: <a class="toggler expand"
style="display: none"
On 2011/11/14 17:34:47, James Hawkins wrote:
> Are these actual links or buttons that look like links?  If the latter, use
the
> link-button class.

I made them proper link buttons.

http://codereview.chromium.org/8555009/diff/1/chrome/browser/resources/policy...
chrome/browser/resources/policy.html:131: <a class="toggler expand"
style="display: none"
On 2011/11/14 17:34:47, James Hawkins wrote:
> Use hidden instead of syle=display none

Done.

http://codereview.chromium.org/8555009/diff/1/chrome/browser/resources/policy.js
File chrome/browser/resources/policy.js (right):

http://codereview.chromium.org/8555009/diff/1/chrome/browser/resources/policy...
chrome/browser/resources/policy.js:144: 
On 2011/11/14 17:34:47, James Hawkins wrote:
> Remove blank line.

Done.

[James Hawkins, 2011-11-14 18:12:35]

http://codereview.chromium.org/8555009/diff/2003/chrome/browser/resources/pol...
File chrome/browser/resources/policy.html (right):

http://codereview.chromium.org/8555009/diff/2003/chrome/browser/resources/pol...
chrome/browser/resources/policy.html:131: <a class="link-button toggler expand"
hidden
You shouldn't use both <a> and link-button.  link-button is for <button>s.

http://codereview.chromium.org/8555009/diff/2003/chrome/browser/resources/pol...
chrome/browser/resources/policy.html:131: <a class="link-button toggler expand"
hidden
nit: No-value attributes should be last, i.e., hidden should be the last
attribute.

[Mattias Nissler (ping if slow), 2011-11-14 18:36:17]

And another try...

http://codereview.chromium.org/8555009/diff/2003/chrome/browser/resources/pol...
File chrome/browser/resources/policy.html (right):

http://codereview.chromium.org/8555009/diff/2003/chrome/browser/resources/pol...
chrome/browser/resources/policy.html:131: <a class="link-button toggler expand"
hidden
On 2011/11/14 18:12:35, James Hawkins wrote:
> You shouldn't use both <a> and link-button.  link-button is for <button>s.

Ah, didn't know that, makes much more sense this way. Thanks for clarifying.

http://codereview.chromium.org/8555009/diff/2003/chrome/browser/resources/pol...
chrome/browser/resources/policy.html:131: <a class="link-button toggler expand"
hidden
On 2011/11/14 18:12:35, James Hawkins wrote:
> nit: No-value attributes should be last, i.e., hidden should be the last
> attribute.

Done.

[James Hawkins, 2011-11-14 19:17:12]

lgtm

[commit-bot: I haz the power, 2011-11-15 09:47:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/8555009/5002

[commit-bot: I haz the power, 2011-11-15 11:27:03]

Change committed as 110070