Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 8554001: base::Bind: Convert content/renderer. (Closed)

Created:
9 years, 1 month ago by James Hawkins
Modified:
9 years, 1 month ago
Reviewers:
csilv
CC:
chromium-reviews, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

base::Bind: Convert content/renderer. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110189

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove includes. #

Patch Set 3 : Test fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -83 lines) Patch
M content/renderer/gpu/gpu_channel_host.cc View 5 chunks +10 lines, -17 lines 0 comments Download
M content/renderer/gpu/transport_texture_host.h View 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/gpu/transport_texture_host.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/gpu/transport_texture_service.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/load_progress_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/load_progress_tracker.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/p2p/p2p_transport_impl_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/p2p/socket_client.cc View 8 chunks +16 lines, -15 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 8 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
9 years, 1 month ago (2011-11-13 01:36:38 UTC) #1
csilv
http://codereview.chromium.org/8554001/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/8554001/diff/1/content/renderer/render_view_impl.cc#newcode13 content/renderer/render_view_impl.cc:13: #include "base/bind_helpers.h" I don't see a use for bind ...
9 years, 1 month ago (2011-11-14 19:56:50 UTC) #2
James Hawkins
http://codereview.chromium.org/8554001/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/8554001/diff/1/content/renderer/render_view_impl.cc#newcode13 content/renderer/render_view_impl.cc:13: #include "base/bind_helpers.h" On 2011/11/14 19:56:51, csilv wrote: > I ...
9 years, 1 month ago (2011-11-14 21:50:49 UTC) #3
csilv
9 years, 1 month ago (2011-11-15 00:45:23 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698