views: Add an Options enum to MessageBoxView control.

chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h

Index: chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h
diff --git a/chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h b/chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h
index c97f5ad89c30eacee6b0dd315f6b085aa7c9dc0a..1c78a919eadde0c55dc286ede4c6a37305f64a2d 100644
--- a/chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h
+++ b/chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h
@@ -12,8 +12,8 @@ class JavaScriptAppModalDialog;
 
 class NativeAppModalDialog {
  public:
-  // Returns the buttons to be shown. See MessageBoxFlags for a description of
-  // the values.
+  // Returns the buttons to be shown. See JavascriptMessageType for a
+  // description of the values.
   virtual int GetAppModalDialogButtons() const = 0;

[sky, 2011/12/01 16:42:02]

This comment is wrong. Isn't this returning DialogButtons? I also think this
method is wrong. Implementations are returning DialogButtons, which doesn't work
as a bitmask. This needs to be straightened out.

[tfarina, 2011/12/01 17:52:58]

Right. Comment reworded.

Although it is working because:

- The values of the enum constants are in the range 0-2, which means in binary
(0, 1, 10), which is the same as 0, 1 << 0, 1 << 1. The thing would become wrong
if a fourth constant would be added to the enum with the value 3 which in binary
is 11, instead of 1 << 2 (4 in decimal and 100 in binary).

I can change the constants in DialogButton to 1 << 0, and 1 << 1, if you think
this is the best solution.
 

 
   // Shows the dialog.