views: Add an Options enum to MessageBoxView control.

chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_APP_MODAL_DIALOGS_NATIVE_APP_MODAL_DIALOG_H_
 #define CHROME_BROWSER_UI_APP_MODAL_DIALOGS_NATIVE_APP_MODAL_DIALOG_H_
 #pragma once
 
 #include "ui/gfx/native_widget_types.h"
 
 class JavaScriptAppModalDialog;
 
 class NativeAppModalDialog {
  public:
-  // Returns the buttons to be shown. See MessageBoxFlags for a description of
-  // the values.
+  // Returns the buttons to be shown. See JavascriptMessageType for a
+  // description of the values.
   virtual int GetAppModalDialogButtons() const = 0;

[sky, 2011/12/01 16:42:02]

This comment is wrong. Isn't this returning DialogButtons? I also think this
method is wrong. Implementations are returning DialogButtons, which doesn't work
as a bitmask. This needs to be straightened out.

[tfarina, 2011/12/01 17:52:58]

Right. Comment reworded.

Although it is working because:

- The values of the enum constants are in the range 0-2, which means in binary
(0, 1, 10), which is the same as 0, 1 << 0, 1 << 1. The thing would become wrong
if a fourth constant would be added to the enum with the value 3 which in binary
is 11, instead of 1 << 2 (4 in decimal and 100 in binary).

I can change the constants in DialogButton to 1 << 0, and 1 << 1, if you think
this is the best solution.
 

 
   // Shows the dialog.
   virtual void ShowAppModalDialog() = 0;
 
   // Activates the dialog.
   virtual void ActivateAppModalDialog() = 0;
 
   // Closes the dialog.
   virtual void CloseAppModalDialog() = 0;
 
   // Accepts or cancels the dialog.
   virtual void AcceptAppModalDialog() = 0;
   virtual void CancelAppModalDialog() = 0;
 
   // Creates an app modal dialog for a JavaScript prompt.
   static NativeAppModalDialog* CreateNativeJavaScriptPrompt(
       JavaScriptAppModalDialog* dialog,
       gfx::NativeWindow parent_window);
 };
 
 #endif  // CHROME_BROWSER_UI_APP_MODAL_DIALOGS_NATIVE_APP_MODAL_DIALOG_H_