Make HistoryDatabase own StarredURLDatabase instead of inheriting from it.

Make HistoryDatabase own StarredURLDatabase instead of inheriting from it.

This switches HistoryDatabase to composition, so the clients doesn't have to
depend/include starred_url_database.h anymore.

NOTE: This was a TODO for sky@.

R=sky@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111179

[sky, 2011-11-21 16:12:16]

http://codereview.chromium.org/8550006/diff/2001/chrome/browser/history/histo...
File chrome/browser/history/history_database.h (right):

http://codereview.chromium.org/8550006/diff/2001/chrome/browser/history/histo...
chrome/browser/history/history_database.h:179: scoped_ptr<StarredURLDatabase>
starred_url_database_;
Do we really need this as a member?

http://codereview.chromium.org/8550006/diff/2001/chrome/browser/history/starr...
File chrome/browser/history/starred_url_database.h (right):

http://codereview.chromium.org/8550006/diff/2001/chrome/browser/history/starr...
chrome/browser/history/starred_url_database.h:27: // Must call any init
functions provided by URLDatabase before using this
Update comment.

[tfarina, 2011-11-21 16:40:38]

http://codereview.chromium.org/8550006/diff/2001/chrome/browser/history/histo...
File chrome/browser/history/history_database.h (right):

http://codereview.chromium.org/8550006/diff/2001/chrome/browser/history/histo...
chrome/browser/history/history_database.h:179: scoped_ptr<StarredURLDatabase>
starred_url_database_;
On 2011/11/21 16:12:16, sky wrote:
> Do we really need this as a member?

Done.

http://codereview.chromium.org/8550006/diff/2001/chrome/browser/history/starr...
File chrome/browser/history/starred_url_database.h (right):

http://codereview.chromium.org/8550006/diff/2001/chrome/browser/history/starr...
chrome/browser/history/starred_url_database.h:27: // Must call any init
functions provided by URLDatabase before using this
On 2011/11/21 16:12:16, sky wrote:
> Update comment.

Done.

[sky, 2011-11-21 17:56:28]

LGTM