Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4157)

Unified Diff: chrome/browser/history/history_database.h

Issue 8550006: Make HistoryDatabase own StarredURLDatabase instead of inheriting from it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sky review Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/history/history_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_database.h
diff --git a/chrome/browser/history/history_database.h b/chrome/browser/history/history_database.h
index f027ebb85f42f8e2946ebcbff1345facb1c16e0a..70f3693b4dce2388fe74e6d888a0dfd28fcb1711 100644
--- a/chrome/browser/history/history_database.h
+++ b/chrome/browser/history/history_database.h
@@ -6,11 +6,12 @@
#define CHROME_BROWSER_HISTORY_HISTORY_DATABASE_H_
#pragma once
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
#include "base/gtest_prod_util.h"
#include "build/build_config.h"
#include "chrome/browser/history/download_database.h"
#include "chrome/browser/history/history_types.h"
-#include "chrome/browser/history/starred_url_database.h"
#include "chrome/browser/history/url_database.h"
#include "chrome/browser/history/visit_database.h"
#include "chrome/browser/history/visitsegment_database.h"
@@ -30,10 +31,7 @@ namespace history {
// as the storage interface. Logic for manipulating this storage layer should
// be in HistoryBackend.cc.
class HistoryDatabase : public DownloadDatabase,
- // TODO(sky): See if we can nuke StarredURLDatabase and just create on the
- // stack for migration. Then HistoryDatabase would directly descend from
- // URLDatabase.
- public StarredURLDatabase,
+ public URLDatabase,
public VisitDatabase,
public VisitSegmentDatabase {
public:
@@ -145,8 +143,8 @@ class HistoryDatabase : public DownloadDatabase,
private:
FRIEND_TEST_ALL_PREFIXES(IconMappingMigrationTest, TestIconMappingMigration);
- // Implemented for URLDatabase.
- virtual sql::Connection& GetDB();
+ // Overridden from URLDatabase:
+ virtual sql::Connection& GetDB() OVERRIDE;
// Migration -----------------------------------------------------------------
« no previous file with comments | « no previous file | chrome/browser/history/history_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698