Facebook : photo upload fails. Give PPB_URLLoader_Impl ability to send credentials when given uni...

Facebook : photo upload fails. Give PPB_URLLoader_Impl ability to send credentials when given universal access.
BUG= http://code.google.com/p/chromium-os/issues/detail?id=22580
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109839

[bbudge, 2011-11-12 06:42:56]

It looks like Flash needs to be able to send credentials, and the default is to
block this. Changing it to give the same privileges as before.

[ilja, 2011-11-12 09:04:01]

On 2011/11/12 06:42:56, bbudge1 wrote:
> It looks like Flash needs to be able to send credentials, and the default is
to
> block this. Changing it to give the same privileges as before.

I think the change should fix things. I will probably be in the lab on Saturday
or Sunday for some other things and will try it. But I think we should land it
by Sunday so testing can resume. So LGTM.

[bbudge, 2011-11-12 14:27:28]

On 2011/11/12 09:04:01, ilja wrote:
> On 2011/11/12 06:42:56, bbudge1 wrote:
> > It looks like Flash needs to be able to send credentials, and the default is
> to
> > block this. Changing it to give the same privileges as before.
> 
> I think the change should fix things. I will probably be in the lab on
Saturday
> or Sunday for some other things and will try it. But I think we should land it
> by Sunday so testing can resume. So LGTM.

Sorry you had to track this down.

[bbudge, 2011-11-12 16:57:31]

On 2011/11/12 14:27:28, bbudge1 wrote:
> On 2011/11/12 09:04:01, ilja wrote:
> > On 2011/11/12 06:42:56, bbudge1 wrote:
> > > It looks like Flash needs to be able to send credentials, and the default
is
> > to
> > > block this. Changing it to give the same privileges as before.
> > 
> > I think the change should fix things. I will probably be in the lab on
> Saturday
> > or Sunday for some other things and will try it. But I think we should land
it
> > by Sunday so testing can resume. So LGTM.
> 
> Sorry you had to track this down.

Trung, I'll try to devise a test to catch this when we go through the PPAPI
tests this week.

[viettrungluu, 2011-11-13 04:35:30]

On 2011/11/12 16:57:31, bbudge1 wrote:
> On 2011/11/12 14:27:28, bbudge1 wrote:
> > On 2011/11/12 09:04:01, ilja wrote:
> > > On 2011/11/12 06:42:56, bbudge1 wrote:
> > > > It looks like Flash needs to be able to send credentials, and the
default
> is
> > > to
> > > > block this. Changing it to give the same privileges as before.
> > > 
> > > I think the change should fix things. I will probably be in the lab on
> > Saturday
> > > or Sunday for some other things and will try it. But I think we should
land
> it
> > > by Sunday so testing can resume. So LGTM.
> > 
> > Sorry you had to track this down.
> 
> Trung, I'll try to devise a test to catch this when we go through the PPAPI
> tests this week.

Thanks. Also, LGTM.

[commit-bot: I haz the power, 2011-11-13 18:42:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/8550002/1

[commit-bot: I haz the power, 2011-11-13 19:52:07]

Change committed as 109839