Facebook : photo upload fails. Give PPB_URLLoader_Impl ability to send credentials when given uni...

webkit/plugins/ppapi/ppb_url_loader_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppb_url_loader_impl.h"
 
 #include "base/logging.h"
 #include "net/base/net_errors.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_errors.h"
@@ skipping 112 matching lines @@
   WebURLRequest web_request;
   if (!request->ToWebURLRequest(frame, &web_request))
     return PP_ERROR_FAILED;
 
   // Save a copy of the request info so the plugin can continue to use and
   // change it while we're doing the request without affecting us. We must do
   // this after ToWebURLRequest since that fills out the file refs.
   request_data_ = request->GetData();
 
   WebURLLoaderOptions options;
-  options.allowCredentials = request_data_.allow_credentials;
   if (has_universal_access_) {
+    options.allowCredentials = true;
     options.crossOriginRequestPolicy =
         WebURLLoaderOptions::CrossOriginRequestPolicyAllow;
   } else {
     // All other HTTP requests are untrusted.
     options.untrustedHTTP = true;
+    options.allowCredentials = request_data_.allow_credentials;
     if (request_data_.allow_cross_origin_requests) {
       // Allow cross-origin requests with access control.
       options.crossOriginRequestPolicy =
           WebURLLoaderOptions::CrossOriginRequestPolicyUseAccessControl;
     }
   }
 
   is_asynchronous_load_suspended_ = false;
   loader_.reset(frame->createAssociatedURLLoader(options));
   if (!loader_.get())
@@ skipping 311 matching lines @@
 bool PPB_URLLoader_Impl::RecordDownloadProgress() const {
   return request_data_.record_download_progress;
 }
 
 bool PPB_URLLoader_Impl::RecordUploadProgress() const {
   return request_data_.record_upload_progress;
 }
 
 }  // namespace ppapi
 }  // namespace webkit