Issue 8549012: Print Preview: Use the global PrintPreviewTabController in unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8549012: Print Preview: Use the global PrintPreviewTabController in unit tests. (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
kmadhusu

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Print Preview: Use the global PrintPreviewTabController in unit tests. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110756

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -13 lines)			Patch
M	chrome/browser/printing/print_preview_tab_controller_unittest.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/base/testing_browser_process.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/test/base/testing_browser_process.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Lei Zhang

This was in http://codereview.chromium.org/7799019, but that CL got reverted.

9 years, 1 month ago (2011-11-18 02:35:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8549012/1

9 years, 1 month ago (2011-11-18 19:29:29 UTC) #3

Change committed as 110756