Print Preview: Add a test for activating the initiator tab on print.

Print Preview: Add a test for activating the initiator tab on print.

BUG=none
TEST=included

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99149

[Lei Zhang, 2011-08-30 20:00:01]

This adds a test for the fix in r98547.

pawel: PTAL at the base/gtest_prod_util.h changes.
kmadhusu: Please review the chrome/ changes.

[Lei Zhang, 2011-08-30 20:47:00]

On 2011/08/30 20:00:01, Lei Zhang wrote:
> This adds a test for the fix in r98547.
> 
> pawel: PTAL at the base/gtest_prod_util.h changes.
> kmadhusu: Please review the chrome/ changes.

Actually, I realized we just need to change TestingBrowserProcess. So that
avoids the need for the new gtest macro for now. I'll have a new patchset in a
bit.

pawel, I'll take you off the reviewers list.

[Lei Zhang, 2011-08-30 21:02:59]

PTAL at patch set 3.

[kmadhusu, 2011-08-31 17:24:38]

http://codereview.chromium.org/7799019/diff/13007/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview_handler_unittest.cc (right):

http://codereview.chromium.org/7799019/diff/13007/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview_handler_unittest.cc:65:
EXPECT_EQ(initiator_tab, browser()->GetSelectedTabContentsWrapper());
Can you also verify that background printing manager has preview tab?

[Lei Zhang, 2011-08-31 21:43:08]

http://codereview.chromium.org/7799019/diff/13007/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview_handler_unittest.cc (right):

http://codereview.chromium.org/7799019/diff/13007/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview_handler_unittest.cc:65:
EXPECT_EQ(initiator_tab, browser()->GetSelectedTabContentsWrapper());
On 2011/08/31 17:24:39, kmadhusu wrote:
> Can you also verify that background printing manager has preview tab?

Done.

[kmadhusu, 2011-08-31 21:59:17]

http://codereview.chromium.org/7799019/diff/15001/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview_handler_unittest.cc (right):

http://codereview.chromium.org/7799019/diff/15001/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview_handler_unittest.cc:24: #if
!defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS)
This code will not be compiled if OS is CrOS. Do you want this defined() macro
here?

http://codereview.chromium.org/7799019/diff/15001/chrome/test/base/testing_br...
File chrome/test/base/testing_browser_process.cc (right):

http://codereview.chromium.org/7799019/diff/15001/chrome/test/base/testing_br...
chrome/test/base/testing_browser_process.cc:202: if
(!print_preview_tab_controller_.get()) {
{} is not required.

[Lei Zhang, 2011-08-31 23:24:04]

http://codereview.chromium.org/7799019/diff/15001/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview_handler_unittest.cc (right):

http://codereview.chromium.org/7799019/diff/15001/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview_handler_unittest.cc:24: #if
!defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS)
On 2011/08/31 21:59:17, kmadhusu wrote:
> This code will not be compiled if OS is CrOS. Do you want this defined() macro
> here?

Yes, just to be consistent with everywhere else.

http://codereview.chromium.org/7799019/diff/15001/chrome/test/base/testing_br...
File chrome/test/base/testing_browser_process.cc (right):

http://codereview.chromium.org/7799019/diff/15001/chrome/test/base/testing_br...
chrome/test/base/testing_browser_process.cc:202: if
(!print_preview_tab_controller_.get()) {
On 2011/08/31 21:59:17, kmadhusu wrote:
> {} is not required.

Done.

[kmadhusu, 2011-08-31 23:27:46]

LGTM

[commit-bot: I haz the power, 2011-09-01 06:49:44]

Change committed as 99149