Issue 8545001: Revert 109774 - Fix slash direction of strip command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8545001: Revert 109774 - Fix slash direction of strip command. (Closed)

Created:
9 years, 1 month ago by noelallen1

Modified:
9 years, 1 month ago

Reviewers:
noelallen_use_chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 109774 - Fix slash direction of strip command. On Windows, the script incorrectly uses '/' regardless of OS. This causes the build to fail. We do not modify the arguments because the strip tool on windows is cygwin based and expects '/' (although it handles '\'). Review URL: http://codereview.chromium.org/8539042 TBR=noelallen@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109775

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	chrome/strip_nacl_irt.py	View		1 chunk	+4 lines, -6 lines	0 comments	Download

Total messages: 1 (0 generated)