Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 8539042: Fix slash direction of strip command. (Closed)

Created:
9 years, 1 month ago by noelallen1
Modified:
9 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Fix slash direction of strip command. On Windows, the script incorrectly uses '/' regardless of OS. This causes the build to fail. We do not modify the arguments because the strip tool on windows is cygwin based and expects '/' (although it handles '\'). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109774

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/strip_nacl_irt.py View 1 chunk +6 lines, -4 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
Rubberstamp with nits. http://codereview.chromium.org/8539042/diff/1/chrome/strip_nacl_irt.py File chrome/strip_nacl_irt.py (right): http://codereview.chromium.org/8539042/diff/1/chrome/strip_nacl_irt.py#newcode45 chrome/strip_nacl_irt.py:45: platform2 + '-strip'), nit: Alignment (this ...
9 years, 1 month ago (2011-11-12 04:29:46 UTC) #1
Ryan Sleevi
9 years, 1 month ago (2011-11-12 04:30:01 UTC) #2
Bah, Rubberstamp LGTM that is

Powered by Google App Engine
This is Rietveld 408576698