Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Unified Diff: chrome/browser/chromeos/login/profile_image_downloader.h

Issue 8541002: [cros] Initial user image loading and repeated profile image loading fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Whitespace Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/profile_image_downloader.h
diff --git a/chrome/browser/chromeos/login/profile_image_downloader.h b/chrome/browser/chromeos/login/profile_image_downloader.h
index 2a9f9094dfc944d4cc3a878b13639f1f1a8aa410..8701b343e0aff683a5c8b48ed01438f9011d405f 100644
--- a/chrome/browser/chromeos/login/profile_image_downloader.h
+++ b/chrome/browser/chromeos/login/profile_image_downloader.h
@@ -34,7 +34,8 @@ class ProfileImageDownloader : public content::URLFetcherDelegate,
kDownloadResultsCount
};
- // Reports on success or failure of Profile image download.
+ // Reports on success or failure of Profile image download. It is OK to
+ // delete the |ProfileImageDownloader| instance in any of these handlers.
class Delegate {
public:
virtual ~Delegate() {}
@@ -55,7 +56,7 @@ class ProfileImageDownloader : public content::URLFetcherDelegate,
// Starts downloading the picture if the necessary authorization token is
// ready. If not, subscribes to token service and starts fetching if the
- // token is available.
+ // token is available. Should not be called more than once.
void Start();
private:
« no previous file with comments | « chrome/browser/chromeos/login/default_user_images.cc ('k') | chrome/browser/chromeos/login/profile_image_downloader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698