[cros] Initial user image loading and repeated profile image loading fixes.

chrome/browser/chromeos/login/profile_image_downloader.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_PROFILE_IMAGE_DOWNLOADER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_PROFILE_IMAGE_DOWNLOADER_H_
 #pragma once
 
 #include <string>
 
@@ skipping 16 matching lines @@
   enum DownloadResult {
     kDownloadSuccessChanged,
     kDownloadSuccess,
     kDownloadFailure,
     kDownloadDefault,
 
     // Must be the last, convenient count.
     kDownloadResultsCount
   };
 
-  // Reports on success or failure of Profile image download.
+  // Reports on success or failure of Profile image download. It is OK to
+  // delete the |ProfileImageDownloader| instance in any of these handlers.
   class Delegate {
    public:
     virtual ~Delegate() {}
 
     // Called when image is successfully downloaded and decoded.
     virtual void OnDownloadSuccess(const SkBitmap& image) = 0;
 
     // Called on download failure.
     virtual void OnDownloadFailure() {}
 
     // Called when user has the default profile image and we won't download
     // it.
     virtual void OnDownloadDefaultImage() {}
   };
 
   explicit ProfileImageDownloader(Delegate* delegate);
   virtual ~ProfileImageDownloader();
 
   // Starts downloading the picture if the necessary authorization token is
   // ready. If not, subscribes to token service and starts fetching if the
-  // token is available.
+  // token is available. Should not be called more than once.
   void Start();
 
  private:
   // Overriden from content::URLFetcherDelegate:
   virtual void OnURLFetchComplete(const content::URLFetcher* source) OVERRIDE;
 
   // Overriden from ImageDecoder::Delegate:
   virtual void OnImageDecoded(const ImageDecoder* decoder,
                               const SkBitmap& decoded_image) OVERRIDE;
   virtual void OnDecodeImageFailed(const ImageDecoder* decoder) OVERRIDE;
@@ skipping 18 matching lines @@
   scoped_ptr<content::URLFetcher> user_entry_fetcher_;
   scoped_ptr<content::URLFetcher> profile_image_fetcher_;
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileImageDownloader);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_PROFILE_IMAGE_DOWNLOADER_H_