Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3345)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 8539038: Add ChromeBrowserMainExtraParts for non main parts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simplify CL. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index eef9057b796942c3ded580bedc5d16ef1a3a8605..ac93c399c0cd3dd915b4550028dcf25b37b4134f 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -218,43 +218,44 @@ RenderProcessHostPrivilege GetProcessPrivilege(
namespace chrome {
-void ChromeContentBrowserClient::CreateBrowserMainParts(
- const content::MainFunctionParams& parameters,
- std::vector<content::BrowserMainParts*>* parts_list) {
+content::BrowserMainParts* ChromeContentBrowserClient::CreateBrowserMainParts(
+ const content::MainFunctionParams& parameters) {
+ ChromeBrowserMainParts *main_parts;
jam 2011/11/14 19:45:55 nit: ChromeBrowserMainParts* main_parts;
stevenjb 2011/11/14 23:31:10 Done.
// Construct the Main browser parts based on the OS type.
#if defined(OS_WIN)
- parts_list->push_back(new ChromeBrowserMainPartsWin(parameters));
+ main_parts = new ChromeBrowserMainPartsWin(parameters);
#elif defined(OS_MACOSX)
- parts_list->push_back(new ChromeBrowserMainPartsMac(parameters));
+ main_parts = new ChromeBrowserMainPartsMac(parameters);
#elif defined(OS_CHROMEOS)
- parts_list->push_back(new ChromeBrowserMainPartsChromeos(parameters));
+ main_parts = new ChromeBrowserMainPartsChromeos(parameters);
#elif defined(OS_LINUX) || defined(OS_OPENBSD)
- parts_list->push_back(new ChromeBrowserMainPartsLinux(parameters));
+ main_parts = new ChromeBrowserMainPartsLinux(parameters);
#elif defined(OS_POSIX)
- parts_list->push_back(new ChromeBrowserMainPartsPosix(parameters));
+ main_parts = new ChromeBrowserMainPartsPosix(parameters);
#else
NOTREACHED();
- parts_list->push_back(new ChromeBrowserMainParts(parameters));
+ main_parts = new ChromeBrowserMainParts(parameters);
#endif
// Construct additional browser parts. Stages are called in the order in
// which they are added.
#if defined(TOOLKIT_USES_GTK)
- parts_list->push_back(new ChromeBrowserPartsGtk());
+ main_parts->AddParts(new ChromeBrowserPartsGtk());
#endif
#if defined(TOOLKIT_VIEWS)
- parts_list->push_back(new ChromeBrowserPartsViews());
+ main_parts->AddParts(new ChromeBrowserPartsViews());
#endif
#if defined(USE_AURA)
- parts_list->push_back(new ChromeBrowserPartsAura());
+ main_parts->AddParts(new ChromeBrowserPartsAura());
#endif
#if defined(TOUCH_UI)
- parts_list->push_back(new ChromeBrowserPartsTouch());
+ main_parts->AddParts(new ChromeBrowserPartsTouch());
#endif
+ return main_parts;
}
RenderWidgetHostView* ChromeContentBrowserClient::CreateViewForWidget(

Powered by Google App Engine
This is Rietveld 408576698