Add ChromeBrowserMainExtraParts for non main parts.

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 200 matching lines @@
       return PRIV_ISOLATED;
   }
 
   return PRIV_EXTENSION;
 }
 
 }  // namespace
 
 namespace chrome {
 
-void ChromeContentBrowserClient::CreateBrowserMainParts(
-    const content::MainFunctionParams& parameters,
-    std::vector<content::BrowserMainParts*>* parts_list) {
+content::BrowserMainParts* ChromeContentBrowserClient::CreateBrowserMainParts(
+    const content::MainFunctionParams& parameters) {
+  ChromeBrowserMainParts *main_parts;

[jam, 2011/11/14 19:45:55]

nit: ChromeBrowserMainParts* main_parts;

[stevenjb, 2011/11/14 23:31:10]

Done.

   // Construct the Main browser parts based on the OS type.
 #if defined(OS_WIN)
-  parts_list->push_back(new ChromeBrowserMainPartsWin(parameters));
+  main_parts = new ChromeBrowserMainPartsWin(parameters);
 #elif defined(OS_MACOSX)
-  parts_list->push_back(new ChromeBrowserMainPartsMac(parameters));
+  main_parts = new ChromeBrowserMainPartsMac(parameters);
 #elif defined(OS_CHROMEOS)
-  parts_list->push_back(new ChromeBrowserMainPartsChromeos(parameters));
+  main_parts = new ChromeBrowserMainPartsChromeos(parameters);
 #elif defined(OS_LINUX) || defined(OS_OPENBSD)
-  parts_list->push_back(new ChromeBrowserMainPartsLinux(parameters));
+  main_parts = new ChromeBrowserMainPartsLinux(parameters);
 #elif defined(OS_POSIX)
-  parts_list->push_back(new ChromeBrowserMainPartsPosix(parameters));
+  main_parts = new ChromeBrowserMainPartsPosix(parameters);
 #else
   NOTREACHED();
-  parts_list->push_back(new ChromeBrowserMainParts(parameters));
+  main_parts = new ChromeBrowserMainParts(parameters);
 #endif
 
   // Construct additional browser parts. Stages are called in the order in
   // which they are added.
 #if defined(TOOLKIT_USES_GTK)
-  parts_list->push_back(new ChromeBrowserPartsGtk());
+  main_parts->AddParts(new ChromeBrowserPartsGtk());
 #endif
 
 #if defined(TOOLKIT_VIEWS)
-  parts_list->push_back(new ChromeBrowserPartsViews());
+  main_parts->AddParts(new ChromeBrowserPartsViews());
 #endif
 
 #if defined(USE_AURA)
-  parts_list->push_back(new ChromeBrowserPartsAura());
+  main_parts->AddParts(new ChromeBrowserPartsAura());
 #endif
 
 #if defined(TOUCH_UI)
-  parts_list->push_back(new ChromeBrowserPartsTouch());
+  main_parts->AddParts(new ChromeBrowserPartsTouch());
 #endif
 
+  return main_parts;
 }
 
 RenderWidgetHostView* ChromeContentBrowserClient::CreateViewForWidget(
     RenderWidgetHost* widget) {
 #if defined(USE_AURA)
   return new RenderWidgetHostViewAura(widget);
 #elif defined(TOUCH_UI)
   return new RenderWidgetHostViewViews(widget);
 #elif defined(OS_WIN)
   if (views::Widget::IsPureViews())
@@ skipping 845 matching lines @@
 #if defined(USE_NSS)
 crypto::CryptoModuleBlockingPasswordDelegate*
     ChromeContentBrowserClient::GetCryptoPasswordDelegate(
         const GURL& url) {
   return browser::NewCryptoModuleBlockingDialogDelegate(
       browser::kCryptoModulePasswordKeygen, url.host());
 }
 #endif
 
 }  // namespace chrome