Fix 3 panel related bugs.

Fix 3 panel related bugs.

Bug 99270: Panels: Changing themes sometimes causes title text to become invisible
The fix is to get the title text when we create the title label because PanelBrowserFrameView will be recreated when the theme is changed.

Bug 102730: Panels on Win: Need an explanatory comment in NativePanelTestingWin::DragTitlebar()
Changed the dragging code to use screen's coordinate system to improve code readability and updated the comments.

Bug 102742: Handle closing the Panel by extension while the settings menu is active
Updated the comments.

BUG=99270, 102730, 102742
TEST=existing tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110148

[Dmitry Titov, 2011-11-12 01:34:53]

LGTM with a nit:

http://codereview.chromium.org/8539035/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_view.cc (right):

http://codereview.chromium.org/8539035/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_view.cc:403: mouse_location_ = location;
The way it's written it can easily look like mixing of coordinate systems,
because mouse_location_ initially is assigned in the view's coordinate system.
Maybe changing order makes it easier to read?

views::View::ConvertPointToScreen(this, &location);
mouse_location_ = location;

[jianli, 2011-11-15 19:26:24]

http://codereview.chromium.org/8539035/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_view.cc (right):

http://codereview.chromium.org/8539035/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_view.cc:403: mouse_location_ = location;
On 2011/11/12 01:34:54, Dmitry Titov wrote:
> The way it's written it can easily look like mixing of coordinate systems,
> because mouse_location_ initially is assigned in the view's coordinate system.
> Maybe changing order makes it easier to read?
> 
> views::View::ConvertPointToScreen(this, &location);
> mouse_location_ = location;

'location' is passed by const reference. So I can't change it.