Fix 3 panel related bugs.

chrome/browser/ui/panels/panel_browser_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_view.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_browser_frame_view.h"
@@ skipping 363 matching lines @@
 
 void PanelBrowserView::DestroyPanelBrowser() {
   DestroyBrowser();
 }
 
 PanelBrowserFrameView* PanelBrowserView::GetFrameView() const {
   return static_cast<PanelBrowserFrameView*>(frame()->GetFrameView());
 }
 
 bool PanelBrowserView::OnTitlebarMousePressed(const gfx::Point& location) {
+  // |location| is in the view's coordinate system. Convert it to the screen
+  // coordinate system.
+  mouse_location_ = location;
+  views::View::ConvertPointToScreen(this, &mouse_location_);
+
   mouse_pressed_ = true;
-  mouse_pressed_point_ = location;
   mouse_pressed_time_ = base::TimeTicks::Now();
   mouse_dragging_state_ = NO_DRAGGING;
   return true;
 }
 
 bool PanelBrowserView::OnTitlebarMouseDragged(const gfx::Point& location) {
   if (!mouse_pressed_)
     return false;
 
-  int delta_x = location.x() - mouse_pressed_point_.x();
-  int delta_y = location.y() - mouse_pressed_point_.y();
+  gfx::Point last_mouse_location = mouse_location_;
+
+  // |location| is in the view's coordinate system. Convert it to the screen
+  // coordinate system.
+  mouse_location_ = location;

[Dmitry Titov, 2011/11/12 01:34:54]

The way it's written it can easily look like mixing of coordinate systems,
because mouse_location_ initially is assigned in the view's coordinate system.
Maybe changing order makes it easier to read?

views::View::ConvertPointToScreen(this, &location);
mouse_location_ = location;

[jianli, 2011/11/15 19:26:24]

'location' is passed by const reference. So I can't change it.

+  views::View::ConvertPointToScreen(this, &mouse_location_);
+
+  int delta_x = mouse_location_.x() - last_mouse_location.x();
+  int delta_y = mouse_location_.y() - last_mouse_location.y();
   if (mouse_dragging_state_ == NO_DRAGGING &&
       ExceededDragThreshold(delta_x, delta_y)) {
     // When a drag begins, we do not want to the client area to still receive
     // the focus.
     old_focused_view_ = GetFocusManager()->GetFocusedView();
     GetFocusManager()->SetFocusedView(GetFrameView());
 
     panel_->manager()->StartDragging(panel_.get());
     mouse_dragging_state_ = DRAGGING_STARTED;
   }
@@ skipping 91 matching lines @@
 void NativePanelTestingWin::PressLeftMouseButtonTitlebar(
     const gfx::Point& point) {
   panel_browser_view_->OnTitlebarMousePressed(point);
 }
 
 void NativePanelTestingWin::ReleaseMouseButtonTitlebar() {
   panel_browser_view_->OnTitlebarMouseReleased();
 }
 
 void NativePanelTestingWin::DragTitlebar(int delta_x, int delta_y) {
-  // TODO(jianli): Need a comment here that explains why we use
-  // mouse_pressed_point_ and not current bounds as obtained by
-  // GetRestoredBounds(). http://crbug.com/102730
-  panel_browser_view_->OnTitlebarMouseDragged(gfx::Point(
-      panel_browser_view_->mouse_pressed_point_.x() + delta_x,
-      panel_browser_view_->mouse_pressed_point_.y() + delta_y));
+  gfx::Point new_mouse_location = panel_browser_view_->mouse_location_;
+  new_mouse_location.Offset(delta_x, delta_y);
+
+  // Convert from the screen coordinate system to the view's coordinate system
+  // since OnTitlebarMouseDragged takes the point in the latter.
+  views::View::ConvertPointToView(NULL, panel_browser_view_,
+                                  &new_mouse_location);
+  panel_browser_view_->OnTitlebarMouseDragged(new_mouse_location);
 }
 
 void NativePanelTestingWin::CancelDragTitlebar() {
   panel_browser_view_->OnTitlebarMouseCaptureLost();
 }
 
 void NativePanelTestingWin::FinishDragTitlebar() {
   panel_browser_view_->OnTitlebarMouseReleased();
 }
 
@@ skipping 18 matching lines @@
 }
 
 bool NativePanelTestingWin::IsWindowSizeKnown() const {
   return true;
 }
 
 bool NativePanelTestingWin::IsAnimatingBounds() const {
   return panel_browser_view_->bounds_animator_.get() &&
          panel_browser_view_->bounds_animator_->is_animating();
 }