Issue 8538016: Revert 109534 since this change broke clobbered component build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8538016: Revert 109534 since this change broke clobbered component build. (Closed)

Created:
9 years, 1 month ago by sadrul

Modified:
9 years, 1 month ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 109534 since this change broke clobbered component build. Original CL: reenable component build w/ fix to test_support_content TBR=jam@chromium.org BUG=90442 TEST=the win shared debug builder compiles Review URL: http://codereview.chromium.org/8501025 TBR=dpranke@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109654

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -61 lines)			Patch
M	chrome/chrome_exe.gypi	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_installer_util.gypi	View	3 chunks	+2 lines, -17 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+0 lines, -20 lines	0 comments	Download
M	chrome/nacl.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/net/url_request_abort_on_end_job.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/common/content_export.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content.gyp	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	webkit/appcache/appcache_export.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/appcache/webkit_appcache.gypi	View	3 chunks	+4 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages