Issue 8501025: reenable component build w/ fix to test_support_content

Issue 8501025: reenable component build w/ fix to test_support_content (Closed)

Created:
9 years, 1 month ago by Dirk Pranke

Modified:
9 years, 1 month ago

Reviewers:
tony

CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

reenable component build w/ fix to test_support_content TBR=jam@chromium.org BUG=90442 TEST=the win shared debug builder compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109534

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -13 lines)			Patch
M	chrome/chrome_exe.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_installer_util.gypi	View	3 chunks	+17 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	chrome/nacl.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/net/url_request_abort_on_end_job.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	content/common/content_export.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content.gyp	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	webkit/appcache/appcache_export.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/appcache/webkit_appcache.gypi	View	3 chunks	+11 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

http://codereview.chromium.org/8501025/diff/1/webkit/appcache/webkit_appcache.gypi File webkit/appcache/webkit_appcache.gypi (right): http://codereview.chromium.org/8501025/diff/1/webkit/appcache/webkit_appcache.gypi#newcode80 webkit/appcache/webkit_appcache.gypi:80: '<(DEPTH)/third_party/WebKit/Source/WebKit/chromium/WebKit.gyp:webkit', This breaks the webkit compile since the path ...

9 years, 1 month ago (2011-11-11 21:31:42 UTC) #1

Dirk Pranke

9 years, 1 month ago (2011-11-11 22:31:41 UTC) #2

On 2011/11/11 21:31:42, tony wrote:
>
http://codereview.chromium.org/8501025/diff/1/webkit/appcache/webkit_appcache...
> File webkit/appcache/webkit_appcache.gypi (right):
> 
>
http://codereview.chromium.org/8501025/diff/1/webkit/appcache/webkit_appcache...
> webkit/appcache/webkit_appcache.gypi:80:
> '<(DEPTH)/third_party/WebKit/Source/WebKit/chromium/WebKit.gyp:webkit',
> This breaks the webkit compile since the path to WebKit.gyp is different when
> we're compiling upstream.  See webkit/glue/webkit_glue.gypi for an example of
> how to use a variable to get the right path based on inside_chromium_build.

Good catch; I will fix.

Expand Messages | Collapse Messages