Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: bin/main.cc

Issue 8537023: Implement automatic loading of dart:core_native_fields library (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: bin/main.cc
===================================================================
--- bin/main.cc (revision 1465)
+++ bin/main.cc (working copy)
@@ -170,7 +170,6 @@
Dart_ExitScope();
exit(255);
}
-
if (!Dart_IsLibrary(library)) {
fprintf(stderr,
"Expected a library when loading script: %s",
@@ -179,8 +178,6 @@
exit(255);
}
Builtin_ImportLibrary(library);
- // Setup the native resolver for built in library functions.
- Builtin_SetNativeResolver();
Anton Muhin 2011/11/13 16:19:32 why it is removed?
siva 2011/11/15 02:16:52 It is not removed, it has been moved into Builtin_
Dart_ExitScope();
return data;
@@ -248,6 +245,10 @@
}
Dart_EnterScope();
+ if (snapshot_buffer != NULL) {
+ // Setup the native resolver as the snapshot does not carry it.
+ Builtin_SetNativeResolver();
Anton Muhin 2011/11/13 16:19:32 why not set builtin native resolver unconditionall
siva 2011/11/15 02:16:52 We don't have to do this for the regular binary as
+ }
if (HasCompileAll(vm_options)) {
Dart_Handle result = Dart_CompileAll();
if (!Dart_IsValid(result)) {

Powered by Google App Engine
This is Rietveld 408576698