Implement automatic loading of dart:core_native_fields library

bin/main.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
 
 #include "include/dart_api.h"
 
@@ skipping 152 matching lines @@
   Dart_EnterScope();
 
   // Load the specified script.
   library = LoadScript(script_name);
   if (!Dart_IsValid(library)) {
     const char* err_msg = Dart_GetError(library);
     fprintf(stderr, "Errors encountered while loading script: %s\n", err_msg);
     Dart_ExitScope();
     exit(255);
   }
-
   if (!Dart_IsLibrary(library)) {
     fprintf(stderr,
             "Expected a library when loading script: %s",
             script_name);
     Dart_ExitScope();
     exit(255);
   }
   Builtin_ImportLibrary(library);
-  // Setup the native resolver for built in library functions.
-  Builtin_SetNativeResolver();

[Anton Muhin, 2011/11/13 16:19:32]

why it is removed?

[siva, 2011/11/15 02:16:52]

It is not removed, it has been moved into Builtin_ImportLibrary in order to
avoid the multiple lookups.


On 2011/11/13 16:19:32, antonmuhin wrote:

 
   Dart_ExitScope();
   return data;
 }
 
 
 static void PrintUsage() {
   fprintf(stderr,
           "dart [<vm-flags>] <dart-script-file> [<dart-options>]\n");
 }
@@ skipping 47 matching lines @@
     return 255;  // Indicates we encountered an error.
   }
   Dart_Isolate isolate = Dart_CreateIsolate(snapshot_buffer,
                                             canonical_script_name);
   if (isolate == NULL) {
     free(canonical_script_name);
     return 255;
   }
 
   Dart_EnterScope();
+  if (snapshot_buffer != NULL) {
+    // Setup the native resolver as the snapshot does not carry it.
+    Builtin_SetNativeResolver();

[Anton Muhin, 2011/11/13 16:19:32]

why not set builtin native resolver unconditionally?  It'll be needed anyway.

[siva, 2011/11/15 02:16:52]

We don't have to do this for the regular binary as it has already been done in
Builtin_importLibrary....

On 2011/11/13 16:19:32, antonmuhin wrote:

+  }
   if (HasCompileAll(vm_options)) {
     Dart_Handle result = Dart_CompileAll();
     if (!Dart_IsValid(result)) {
       fprintf(stderr, "%s\n", Dart_GetError(result));
       Dart_ExitScope();
       Dart_ShutdownIsolate();
       free(canonical_script_name);
       return 255;  // Indicates we encountered an error.
     }
   }
@@ skipping 57 matching lines @@
     return 255;  // Indicates we encountered an error.
   }
   free(canonical_script_name);
   Dart_ExitScope();
   // Dump symbol information for the profiler.
   DumpPprofSymbolInfo();
   // Shutdown the isolate.
   Dart_ShutdownIsolate();
   return 0;
 }