ChromeOS should record FileBrowser.CreateNewFolder.... events

chrome/tools/extract_actions.py

Index: chrome/tools/extract_actions.py
diff --git a/chrome/tools/extract_actions.py b/chrome/tools/extract_actions.py
index 739e3ee6529ac9d6392f8b76d7bff118a0857bcf..342408fc2630e6a27b14b7327f6a30bc65edad95 100755
--- a/chrome/tools/extract_actions.py
+++ b/chrome/tools/extract_actions.py
@@ -223,6 +223,9 @@ def AddChromeOSActions(actions):
   # Actions sent by Chrome OS cryptohome.
   actions.add('Cryptohome.PKCS11InitFail')
 
+  # Actions sent by Chrome OS File Browser.
+  actions.add('FileBrowser.CreateNewFolder.hhaomjibdihmijegdhdafkllkbggdgoj')

[petkov, 2011/11/14 13:25:27]

Is this user action reported by the Chrome process or a non-Chrome process? I'm
not sure that this function (as is) is the right place to add the action (see
the docstring) -- it was meant for user actions that came through ChromeOS's
libmetrics API which are processed by Chrome's ChromeOS-specific
external_metrics.cc.

If there's no better place to add the new action you could either change the
docstring or add a new function. Is the FileBrowser really ChromeOS-specific?

[Vladislav Kaznacheev, 2011/11/14 13:53:19]

The File Browser is ChromeOS specific. It lives in the Chrome codebase and runs
as a Chrome extension but it is only enabled in Chrome OS.

I have added a dedicated function for this kind of actions.

On 2011/11/14 13:25:27, petkov wrote:

+
 def GrepForActions(path, actions):
   """Grep a source file for calls to UserMetrics functions.