ChromeOS should record FileBrowser.CreateNewFolder.... events

chrome/tools/extract_actions.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Extract UserMetrics "actions" strings from the Chrome source.
 
 This program generates the list of known actions we expect to see in the
 user behavior logs.  It walks the Chrome source, looking for calls to
 UserMetrics functions, extracting actions and warning on improper calls,
@@ skipping 205 matching lines @@
   actions.add('Accel_BrightnessDown_F6')
   actions.add('Accel_BrightnessUp_F7')
 
   # Actions sent by Chrome OS update engine.
   actions.add('Updater.ServerCertificateChanged')
   actions.add('Updater.ServerCertificateFailed')
 
   # Actions sent by Chrome OS cryptohome.
   actions.add('Cryptohome.PKCS11InitFail')
 
+  # Actions sent by Chrome OS File Browser.
+  actions.add('FileBrowser.CreateNewFolder.hhaomjibdihmijegdhdafkllkbggdgoj')

[petkov, 2011/11/14 13:25:27]

Is this user action reported by the Chrome process or a non-Chrome process? I'm
not sure that this function (as is) is the right place to add the action (see
the docstring) -- it was meant for user actions that came through ChromeOS's
libmetrics API which are processed by Chrome's ChromeOS-specific
external_metrics.cc.

If there's no better place to add the new action you could either change the
docstring or add a new function. Is the FileBrowser really ChromeOS-specific?

[Vladislav Kaznacheev, 2011/11/14 13:53:19]

The File Browser is ChromeOS specific. It lives in the Chrome codebase and runs
as a Chrome extension but it is only enabled in Chrome OS.

I have added a dedicated function for this kind of actions.

On 2011/11/14 13:25:27, petkov wrote:

+
 def GrepForActions(path, actions):
   """Grep a source file for calls to UserMetrics functions.
 
   Arguments:
     path: path to the file
     actions: set of actions to add to
   """
   global number_of_files_total
   number_of_files_total = number_of_files_total + 1
   # we look for the UserMetricsAction structure constructor
@@ skipping 189 matching lines @@
       hash.update(action)
       print >>f, '0x%s\t%s' % (hash.hexdigest()[:16], action)
     else:
       print action
 
   if hash_output:
     print "Done. Do not forget to add chromeactions.txt to your changelist"
 
 if '__main__' == __name__:
   main(sys.argv)