Convert MessageBoxFlags class into an enum.

chrome/browser/ui/views/repost_form_warning_view.cc

Index: chrome/browser/ui/views/repost_form_warning_view.cc
diff --git a/chrome/browser/ui/views/repost_form_warning_view.cc b/chrome/browser/ui/views/repost_form_warning_view.cc
index c7ade240707458cdc4cdb96f6d5e83b403a6ffc3..e53957a24e094a0550c7118adf6aba2147dbb06f 100644
--- a/chrome/browser/ui/views/repost_form_warning_view.cc
+++ b/chrome/browser/ui/views/repost_form_warning_view.cc
@@ -36,7 +36,7 @@ RepostFormWarningView::RepostFormWarningView(
       : controller_(new RepostFormWarningController(tab_contents)),
         message_box_view_(NULL) {
   message_box_view_ = new views::MessageBoxView(
-      ui::MessageBoxFlags::kIsConfirmMessageBox,
+      ui::MESSAGE_BOX_IS_CONFIRM_DIALOG,

[tfarina, 2011/11/12 12:40:22]

MessageBoxView does not check any of the flags passed in from
kIsConfirmMessageBox. It just cares about kAutoDetectAlignment and
kFlagHasPromptField. I think I'll make an enum into MessageBoxView for these two
flags instead.

With this I can kill kIsConfirmMessageBox, because it's only passed to
MessageBoxView, but actually not used by MessageBoxView.

[tfarina, 2011/11/12 22:33:56]

Scott, I think this patch http://codereview.chromium.org/8553001/ should give
you a better idea of what I have in mind.

The changes I think are most important are in:
simple_message_box_views.cc and js_modal_dialog_views.cc

       l10n_util::GetStringUTF16(IDS_HTTP_POST_WARNING),
       string16());
   TabContentsWrapper* wrapper =