Convert MessageBoxFlags class into an enum.

chrome/browser/ui/views/repost_form_warning_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/repost_form_warning_view.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/repost_form_warning_controller.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
@@ skipping 18 matching lines @@
 
 //////////////////////////////////////////////////////////////////////////////
 // RepostFormWarningView, constructor & destructor:
 
 RepostFormWarningView::RepostFormWarningView(
     gfx::NativeWindow parent_window,
     TabContents* tab_contents)
       : controller_(new RepostFormWarningController(tab_contents)),
         message_box_view_(NULL) {
   message_box_view_ = new views::MessageBoxView(
-      ui::MessageBoxFlags::kIsConfirmMessageBox,
+      ui::MESSAGE_BOX_IS_CONFIRM_DIALOG,

[tfarina, 2011/11/12 12:40:22]

MessageBoxView does not check any of the flags passed in from
kIsConfirmMessageBox. It just cares about kAutoDetectAlignment and
kFlagHasPromptField. I think I'll make an enum into MessageBoxView for these two
flags instead.

With this I can kill kIsConfirmMessageBox, because it's only passed to
MessageBoxView, but actually not used by MessageBoxView.

[tfarina, 2011/11/12 22:33:56]

Scott, I think this patch http://codereview.chromium.org/8553001/ should give
you a better idea of what I have in mind.

The changes I think are most important are in:
simple_message_box_views.cc and js_modal_dialog_views.cc

       l10n_util::GetStringUTF16(IDS_HTTP_POST_WARNING),
       string16());
   TabContentsWrapper* wrapper =
       TabContentsWrapper::GetCurrentWrapperForContents(tab_contents);
   controller_->set_window(new ConstrainedWindowViews(wrapper, this));
 }
 
 RepostFormWarningView::~RepostFormWarningView() {
 }
 
@@ skipping 34 matching lines @@
   controller_->Continue();
   return true;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // RepostFormWarningView, RepostFormWarning implementation:
 
 void RepostFormWarningView::DeleteDelegate() {
   delete this;
 }