Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 8536023: Don't try to delete file type ownership at uninstall. (Closed)

Created:
9 years, 1 month ago by grt (UTC plus 2)
Modified:
9 years, 1 month ago
Reviewers:
robertshield
CC:
chromium-reviews
Visibility:
Public.

Description

Don't try to delete file type ownership at uninstall. As per http://msdn.microsoft.com/en-us/library/windows/desktop/cc144148(v=vs.85).aspx#uninstall BUG=103935 TEST=install Chrome, make it the default, then uninstall it. make sure HKLM\Software\Classes\.htm hasn't been deleted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M chrome/installer/setup/uninstall.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
9 years, 1 month ago (2011-11-11 19:34:43 UTC) #1
robertshield
LGTM
9 years, 1 month ago (2011-11-11 19:37:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/8536023/1
9 years, 1 month ago (2011-11-11 19:39:26 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 21:24:40 UTC) #4
Change committed as 109698

Powered by Google App Engine
This is Rietveld 408576698