Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8314)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 8536023: Don't try to delete file type ownership at uninstall. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index b25b03cc85c705287f7aa619a073fbf14de79d39..6538eab00683d649a5dcf51c67c2ef6316f42d2d 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -623,16 +623,9 @@ bool DeleteChromeRegistrationKeys(BrowserDistribution* dist, HKEY root,
open_command_pred);
}
- // Delete each filetype association if it references this Chrome.
- InstallUtil::ValueEquals prog_id_pred(ShellUtil::kChromeHTMLProgId +
- browser_entry_suffix);
- for (const wchar_t* const* filetype = &ShellUtil::kFileAssociations[0];
- *filetype != NULL; ++filetype) {
- parent_key.resize(base_length);
- file_util::AppendToPath(&parent_key, *filetype);
- InstallUtil::DeleteRegistryKeyIf(root, parent_key, parent_key, L"",
- prog_id_pred);
- }
+ // Note that we do not attempt to delete filetype associations since MSDN
+ // says "Windows respects the Default value only if the ProgID found there is
+ // a registered ProgID. If the ProgID is unregistered, it is ignored."
*exit_code = installer::UNINSTALL_SUCCESSFUL;
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698