Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 8533028: RSAPrivateKey vector push_back cleanups. (Closed)

Created:
9 years, 1 month ago by mattm
Modified:
9 years, 1 month ago
Reviewers:
wtc
CC:
chromium-reviews
Visibility:
Public.

Description

RSAPrivateKey vector push_back cleanups. BUG=none TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M crypto/rsa_private_key.cc View 4 chunks +4 lines, -10 lines 0 comments Download
M crypto/rsa_private_key_nss.cc View 1 chunk +1 line, -3 lines 0 comments Download
M crypto/rsa_private_key_win.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mattm
(There's still the issue of PrivateKeyInfoCodec using a std::list<uint8> to build up the output before ...
9 years, 1 month ago (2011-11-15 02:07:58 UTC) #1
wtc
LGTM.
9 years, 1 month ago (2011-11-15 03:24:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/8533028/1
9 years, 1 month ago (2011-11-15 03:36:17 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 04:45:17 UTC) #4
Change committed as 110043

Powered by Google App Engine
This is Rietveld 408576698