RSAPrivateKey vector push_back cleanups.

crypto/rsa_private_key.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/rsa_private_key.h"
 
 #include <algorithm>
 #include <list>
 
 #include "base/logging.h"
@@ skipping 63 matching lines @@
 
   // RSA algorithm OID
   for (size_t i = sizeof(kRsaAlgorithmIdentifier); i > 0; --i)
     content.push_front(kRsaAlgorithmIdentifier[i - 1]);
 
   PrependInteger(&version, 1, &content);
   PrependTypeHeaderAndLength(kSequenceTag, content.size(), &content);
 
   // Copy everying into the output.
   output->reserve(content.size());
-  for (std::list<uint8>::iterator i = content.begin(); i != content.end(); ++i)
-    output->push_back(*i);
+  output->assign(content.begin(), content.end());
 
   return true;
 }
 
 bool PrivateKeyInfoCodec::ExportPublicKeyInfo(std::vector<uint8>* output) {
   // Create a sequence with the modulus (n) and public exponent (e).
   std::vector<uint8> bit_string;
   if (!ExportPublicKey(&bit_string))
     return false;
 
   // Add the sequence as the contents of a bit string.
   std::list<uint8> content;
   PrependBitString(&bit_string[0], static_cast<int>(bit_string.size()),
                    &content);
 
   // Add the RSA algorithm OID.
   for (size_t i = sizeof(kRsaAlgorithmIdentifier); i > 0; --i)
     content.push_front(kRsaAlgorithmIdentifier[i - 1]);
 
   // Finally, wrap everything in a sequence.
   PrependTypeHeaderAndLength(kSequenceTag, content.size(), &content);
 
   // Copy everything into the output.
   output->reserve(content.size());
-  for (std::list<uint8>::iterator i = content.begin(); i != content.end(); ++i)
-    output->push_back(*i);
+  output->assign(content.begin(), content.end());
 
   return true;
 }
 
 bool PrivateKeyInfoCodec::ExportPublicKey(std::vector<uint8>* output) {
   // Create a sequence with the modulus (n) and public exponent (e).
   std::list<uint8> content;
   PrependInteger(&public_exponent_[0],
                  static_cast<int>(public_exponent_.size()),
                  &content);
   PrependInteger(&modulus_[0],  static_cast<int>(modulus_.size()), &content);
   PrependTypeHeaderAndLength(kSequenceTag, content.size(), &content);
 
   // Copy everything into the output.
   output->reserve(content.size());
-  for (std::list<uint8>::iterator i = content.begin(); i != content.end(); ++i)
-    output->push_back(*i);
+  output->assign(content.begin(), content.end());
 
   return true;
 }
 
 bool PrivateKeyInfoCodec::Import(const std::vector<uint8>& input) {
   if (input.empty()) {
     return false;
   }
 
   // Parse the private key info up to the public key values, ignoring
@@ skipping 92 matching lines @@
   int pad = expected_size - temp.size();
   int index = 0;
   if (out->size() == expected_size + 1) {
     READ_ASSERT(out->front() == 0x00);
     pad++;
     index++;
   } else {
     READ_ASSERT(out->size() <= expected_size);
   }
 
-  while (pad) {
-    out->push_back(0x00);
-    pad--;
-  }
+  out->insert(out->end(), pad, 0x00);
   out->insert(out->end(), temp.begin(), temp.end());
 
   // Reverse output if little-endian.
   if (!big_endian_)
     reverse(out->begin(), out->end());
   return true;
 }
 
 bool PrivateKeyInfoCodec::ReadIntegerImpl(uint8** pos,
                                           uint8* end,
@@ skipping 126 matching lines @@
   // The version should be zero.
   for (uint32 i = 0; i < length; ++i) {
     READ_ASSERT(**pos == 0x00);
     (*pos)++;
   }
 
   return true;
 }
 
 }  // namespace crypto