Instrument the downloads database to aid debugging 103610

Check dbg_statement.Succeeded() in RemoveDownloadsBetween.

If the crash in CreateDownload moves here, then records are being removed from the table even though their ids are not being removed from returned_ids_. If the crash stays in CreateDownload, then there must be some other place where records are being removed from the table even though their ids are not being removed from returned_ids_.

BUG=103610
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110947

[benjhayden, 2011-11-14 20:09:34]

PTAL

[benjhayden, 2011-11-14 20:58:46]

17.0.932.0 landed on all platforms on the dev channel 7 days ago.

0.06% of mac crashes 
http://chromecrash/browse?q=v%3DChrome_Mac-17.0.932.0%2Fptype%3Dbrowser%2Fmag...

0.47% on win32
http://chromecrash/browse?q=v%3DChrome-17.0.932.0%2Fptype%3Dbrowser

0.03% on linux
http://chromecrash/browse?q=v%3DChrome_Linux-17.0.932.0%2Fptype%3Dbrowser%2Fm...

[Randy Smith (Not in Mondays), 2011-11-14 22:11:12]

LGTM.

FWIW, My evaluation of the crash numbers is that this is worth fixing, but not
worth shoving other priorities down for.  So I'd work on this as you have time
in the background.

[commit-bot: I haz the power, 2011-11-18 18:11:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/8528037/4001

[commit-bot: I haz the power, 2011-11-18 19:29:23]

Try job failure for 8528037-4001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-21 16:04:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/8528037/8001

[commit-bot: I haz the power, 2011-11-21 17:12:35]

Change committed as 110947