Instrument the downloads database to aid debugging 103610

chrome/browser/history/download_database.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/download_database.h"
 
 #include <limits>
 #include <string>
 #include <vector>
 
@@ skipping 216 matching lines @@
     dbg_statement.BindInt64(
         1,
         end_time ? end_time : std::numeric_limits<int64>::max());
     dbg_statement.BindInt(2, DownloadItem::COMPLETE);
     dbg_statement.BindInt(3, DownloadItem::CANCELLED);
     dbg_statement.BindInt(4, DownloadItem::INTERRUPTED);
     while (dbg_statement.Step()) {
       int64 id_to_delete = dbg_statement.ColumnInt64(0);
       returned_ids_.erase(id_to_delete);
     }
+    CHECK(dbg_statement.Succeeded());
   }
 
   // This does not use an index. We currently aren't likely to have enough
   // downloads where an index by time will give us a lot of benefit.
   sql::Statement statement(GetDB().GetCachedStatement(SQL_FROM_HERE,
       "DELETE FROM downloads WHERE start_time >= ? AND start_time < ? "
       "AND (State = ? OR State = ? OR State = ?)"));
   if (!statement)
     return;
 
   statement.BindInt64(0, start_time);
   statement.BindInt64(
       1,
       end_time ? end_time : std::numeric_limits<int64>::max());
   statement.BindInt(2, DownloadItem::COMPLETE);
   statement.BindInt(3, DownloadItem::CANCELLED);
   statement.BindInt(4, DownloadItem::INTERRUPTED);
   statement.Run();
 }
 
 }  // namespace history