Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: src/profile-generator.cc

Issue 8528024: Fix missing HandleScope to prevent local handles to DOMWindow leaking. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.cc
diff --git a/src/profile-generator.cc b/src/profile-generator.cc
index 1a2d005a6feb927f490de53361ad8886a3f041d4..6a31a7c24cca6c2070e621414d4f3dc999b81abf 100644
--- a/src/profile-generator.cc
+++ b/src/profile-generator.cc
@@ -2473,6 +2473,7 @@ void V8HeapExplorer::TagGlobalObjects() {
Isolate* isolate = Isolate::Current();
GlobalObjectsEnumerator enumerator;
isolate->global_handles()->IterateAllRoots(&enumerator);
+ HandleScope scope;
Erik Corry 2011/11/14 23:02:50 Perhaps better to have this in the loop. As it is
mnaganov (inactive) 2011/11/15 09:58:27 The number of global objects is usually limited. B
Vitaly Repeshko 2011/11/15 18:55:59 This is too late. Global object handles have alrea
mnaganov (inactive) 2011/11/15 19:56:18 A good catch! %)
Handle<String> document_string =
isolate->factory()->NewStringFromAscii(CStrVector("document"));
Handle<String> url_string =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698