Fix missing HandleScope to prevent local handles to DOMWindow leaking.

src/profile-generator.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2455 matching lines @@
  private:
   List<Handle<JSGlobalObject> > objects_;
 };
 
 
 // Modifies heap. Must not be run during heap traversal.
 void V8HeapExplorer::TagGlobalObjects() {
   Isolate* isolate = Isolate::Current();
   GlobalObjectsEnumerator enumerator;
   isolate->global_handles()->IterateAllRoots(&enumerator);
+  HandleScope scope;

[Erik Corry, 2011/11/14 23:02:50]

Perhaps better to have this in the loop.  As it is now, an unlimited number of
handles is ceated (depending on enumerator.count()).  It is good that they are
destroyed at the end of this function, but it seems even better if they are
destroyed at the end of each loop iteration.

[mnaganov (inactive), 2011/11/15 09:58:27]

The number of global objects is usually limited. But OK, shorting handles lives
even more seems good to me.

[Vitaly Repeshko, 2011/11/15 18:55:59]

This is too late. Global object handles have already been created in
GlobalObjectsEnumerator.

[mnaganov (inactive), 2011/11/15 19:56:18]

A good catch! %)

   Handle<String> document_string =
       isolate->factory()->NewStringFromAscii(CStrVector("document"));
   Handle<String> url_string =
       isolate->factory()->NewStringFromAscii(CStrVector("URL"));
   const char** urls = NewArray<const char*>(enumerator.count());
   for (int i = 0, l = enumerator.count(); i < l; ++i) {
     urls[i] = NULL;
     Handle<JSGlobalObject> global_obj = enumerator.at(i);
     Object* obj_document;
     if (global_obj->GetProperty(*document_string)->ToObject(&obj_document) &&
@@ skipping 955 matching lines @@
 
 
 void HeapSnapshotJSONSerializer::SortHashMap(
     HashMap* map, List<HashMap::Entry*>* sorted_entries) {
   for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p))
     sorted_entries->Add(p);
   sorted_entries->Sort(SortUsingEntryValue);
 }
 
 } }  // namespace v8::internal