Fix missing HandleScope to prevent local handles to DOMWindow leaking.

Fix missing HandleScope to prevent local handles to DOMWindow leaking.

R=erik.corry@gmail.com
BUG=102895
TEST=none

Committed: http://code.google.com/p/v8/source/detail?r=9994

[Erik Corry, 2011-11-14 23:02:50]

LGTM

http://codereview.chromium.org/8528024/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/8528024/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:2476: HandleScope scope;
Perhaps better to have this in the loop.  As it is now, an unlimited number of
handles is ceated (depending on enumerator.count()).  It is good that they are
destroyed at the end of this function, but it seems even better if they are
destroyed at the end of each loop iteration.

[mnaganov (inactive), 2011-11-15 09:58:27]

http://codereview.chromium.org/8528024/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/8528024/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:2476: HandleScope scope;
On 2011/11/14 23:02:50, Erik Corry wrote:
> Perhaps better to have this in the loop.  As it is now, an unlimited number of
> handles is ceated (depending on enumerator.count()).  It is good that they are
> destroyed at the end of this function, but it seems even better if they are
> destroyed at the end of each loop iteration.

The number of global objects is usually limited. But OK, shorting handles lives
even more seems good to me.

[Vitaly Repeshko, 2011-11-15 18:55:59]

http://codereview.chromium.org/8528024/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/8528024/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:2476: HandleScope scope;
This is too late. Global object handles have already been created in
GlobalObjectsEnumerator.

[mnaganov (inactive), 2011-11-15 19:56:16]

http://codereview.chromium.org/8528024/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/8528024/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:2476: HandleScope scope;
On 2011/11/15 18:55:59, Vitaly Repeshko wrote:
> This is too late. Global object handles have already been created in
> GlobalObjectsEnumerator.

A good catch! %)