Issue 8528016: Fix leak in BroadcastNotifications() if the delegate is closing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8528016: Fix leak in BroadcastNotifications() if the delegate is closing (Closed)

Created:
9 years, 1 month ago by Andrew T Wilson (Slow)

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix leak in BroadcastNotifications() if the delegate is closing BUG=86483 TEST=run tests under valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109690

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -13 lines)			Patch
	M	chrome/browser/history/history_backend.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/8528016/1

9 years, 1 month ago (2011-11-11 19:12:01 UTC) #3

Change committed as 109690