chrome/browser/history/history_backend.cc - Issue 8528016: Fix leak in BroadcastNotifications() if the delegate is closing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_backend.cc

Issue 8528016: Fix leak in BroadcastNotifications() if the delegate is closing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history_backend.cc

diff --git a/chrome/browser/history/history_backend.cc b/chrome/browser/history/history_backend.cc

index d16c6c67f6e474aa3a6bae2858f64660445cba2f..92f06c18bc6b224996d633e187683ebf5f86279c 100644

--- a/chrome/browser/history/history_backend.cc

+++ b/chrome/browser/history/history_backend.cc

@@ -2076,6 +2076,8 @@ void HistoryBackend::BroadcastNotifications(

// HistoryService -> HistroyBackend::Closing().

if (delegate_.get())

delegate_->BroadcastNotifications(type, details_deleted);

+ else

+ delete details_deleted;

}

// Deleting --------------------------------------------------------------------

« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »