Issue 8526020: aura: Track mouse button state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8526020: aura: Track mouse button state. (Closed)

Created:
9 years, 1 month ago by Daniel Erat

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, dhollowa, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Track mouse button state. This removes a NOTIMPLEMENTED() in views::NativeWidgetPrivate::IsMouseButtonDown(). BUG=102577 TEST=added Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109703

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix windows compilation error #

Patch Set 3 : change format string #

Patch Set 4 : merge #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -8 lines)			Patch
M	ui/aura/aura.gyp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/desktop.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	ui/aura/desktop.cc	View	1 2 3	4 chunks	+12 lines, -0 lines	0 comments	Download
M	ui/aura/desktop_unittest.cc	View	1 2 3	2 chunks	+51 lines, -2 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_aura.cc	View	1 2 3	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

http://codereview.chromium.org/8526020/diff/1/ui/aura/window_unittest.cc File ui/aura/window_unittest.cc (left): http://codereview.chromium.org/8526020/diff/1/ui/aura/window_unittest.cc#oldcode887 ui/aura/window_unittest.cc:887: base::StringPrintf("name=%s old=%ld new=%ld", this was breaking compilation for 32-bit. ...

9 years, 1 month ago (2011-11-11 00:25:57 UTC) #1

lgtm

Expand Messages | Collapse Messages