Cleanup: Remove unneeded forward declararations in net.

Cleanup: Remove unneeded forward declararations in net.

BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109590

[eroman, 2011-11-11 02:24:23]

LGTM

On Thu, Nov 10, 2011 at 6:19 PM, <thestig@chromium.org> wrote:

> Reviewers: eroman,
>
> Description:
> Cleanup: Remove unneeded forward declararations in net.
>
> BUG=none
> TEST=none
>
> Please review this at
http://codereview.chromium.**org/8525020/<http://codereview.chromium.org/8525...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     net/base/host_resolver.h
>  M     net/base/network_delegate.h
>  M     net/curvecp/messenger.h
>  M     net/curvecp/received_block_**list.h
>  M     net/dns/async_host_resolver.h
>  M     net/dns/watching_file_reader.h
>  M     net/http/http_cache_**transaction.h
>  M     net/http/http_network_**transaction.h
>  M     net/http/http_pipelined_**stream.h
>  M     net/http/http_proxy_client_**socket.h
>  M     net/http/http_stream_factory.h
>  M     net/http/http_stream_factory_**impl_job.h
>  M     net/http/http_util.h
>  M     net/proxy/dhcp_proxy_script_**adapter_fetcher_win.h
>  M     net/proxy/init_proxy_resolver.**h
>  M     net/proxy/proxy_script_**fetcher_impl.h
>  M     net/proxy/proxy_service.h
>  M     net/server/http_connection.h
>  M     net/socket/client_socket_**factory.h
>  M     net/socket/ssl_client_socket_**pool.h
>  M     net/socket/ssl_server_socket.h
>  M     net/spdy/spdy_proxy_client_**socket.h
>  net/spdy/spdy_session_pool.h
>  M     net/tools/flip_server/spdy_**interface.h
>  M     net/url_request/url_request.h
>  M     net/url_request/url_request_**test_util.h
>
>
> Index: net/base/host_resolver.h
> ==============================**==============================**=======
> --- net/base/host_resolver.h    (revision 109476)
> +++ net/base/host_resolver.h    (working copy)
> @@ -22,7 +22,6 @@
>  class AddressList;
>  class BoundNetLog;
>  class HostCache;
> -class HostResolverImpl;
>  class HostResolverProc;
>  class NetLog;
>
> Index: net/base/network_delegate.h
> ==============================**==============================**=======
> --- net/base/network_delegate.h (revision 109476)
> +++ net/base/network_delegate.h (working copy)
> @@ -26,7 +26,6 @@
>  // NOTE: It is not okay to add any compile-time dependencies on symbols
> outside
>  // of net/base here, because we have a net_base library. Forward
> declarations
>  // are ok.
> -class HostPortPair;
>  class HttpRequestHeaders;
>  class HttpResponseHeaders;
>  class URLRequest;
> Index: net/curvecp/messenger.h
> ==============================**==============================**=======
> --- net/curvecp/messenger.h     (revision 109476)
> +++ net/curvecp/messenger.h     (working copy)
> @@ -23,7 +23,6 @@
>
>  namespace net {
>
> -class DrainableIOBuffer;
>  class IOBufferWithSize;
>  class Packetizer;
>
> Index: net/curvecp/received_block_**list.h
> ==============================**==============================**=======
> --- net/curvecp/received_block_**list.h   (revision 109476)
> +++ net/curvecp/received_block_**list.h   (working copy)
> @@ -13,7 +13,6 @@
>
>  class DrainableIOBuffer;
>  class IOBuffer;
> -class IOBufferWithSize;
>
>  // A ReceivedBlockList manages everything needed to track a set of of
> incoming
>  // blocks.  It can coalesce continuous blocks and locate holes in the
> received
> Index: net/dns/async_host_resolver.h
> ==============================**==============================**=======
> --- net/dns/async_host_resolver.h       (revision 109476)
> +++ net/dns/async_host_resolver.h       (working copy)
> @@ -21,7 +21,6 @@
>
>  namespace net {
>
> -class AddressesList;
>  class ClientSocketFactory;
>
>  class NET_EXPORT AsyncHostResolver
> Index: net/dns/watching_file_reader.h
> ==============================**==============================**=======
> --- net/dns/watching_file_reader.h      (revision 109476)
> +++ net/dns/watching_file_reader.h      (working copy)
> @@ -16,11 +16,6 @@
>  #include "net/base/net_export.h"
>  #include "net/dns/serial_worker.h"
>
> -// Forward declaration
> -namespace base {
> -class MessageLoopProxy;
> -}
> -
>  namespace net {
>
>  // Allows mocking FilePathWatcher
> @@ -93,4 +88,3 @@
>  }  // namespace net
>
>  #endif  // NET_DNS_WATCHING_FILE_READER_**H_
> -
> Index: net/http/http_cache_**transaction.h
> ==============================**==============================**=======
> --- net/http/http_cache_**transaction.h   (revision 109476)
> +++ net/http/http_cache_**transaction.h   (working copy)
> @@ -20,7 +20,6 @@
>
>  namespace net {
>
> -class HttpResponseHeaders;
>  class PartialData;
>  struct HttpRequestInfo;
>
> @@ -57,7 +56,7 @@
>     UPDATE          = READ_META | WRITE,  // READ_WRITE & ~READ_DATA
>   };
>
> -  Transaction(HttpCache* cache);
> +  explicit Transaction(HttpCache* cache);
>   virtual ~Transaction();
>
>   Mode mode() const { return mode_; }
> @@ -79,7 +78,9 @@
>   // response (or response info) must be evaluated by the caller, for
> instance
>   // to make sure that the response_time is as expected, before calling
> this
>   // method.
> -  int WriteMetadata(IOBuffer* buf, int buf_len, OldCompletionCallback*
> callback);
> +  int WriteMetadata(IOBuffer* buf,
> +                    int buf_len,
> +                    OldCompletionCallback* callback);
>
>   // This transaction is being deleted and we are not done writing to the
> cache.
>   // We need to indicate that the response data was truncated.  Returns
> true on
> Index: net/http/http_network_**transaction.h
> ==============================**==============================**=======
> --- net/http/http_network_**transaction.h (revision 109476)
> +++ net/http/http_network_**transaction.h (working copy)
> @@ -30,6 +30,7 @@
>  class HttpStream;
>  class HttpStreamRequest;
>  class IOBuffer;
> +class UploadDataStream;
>  struct HttpRequestInfo;
>
>  class NET_EXPORT_PRIVATE HttpNetworkTransaction
> Index: net/http/http_pipelined_**stream.h
> ==============================**==============================**=======
> --- net/http/http_pipelined_**stream.h    (revision 109476)
> +++ net/http/http_pipelined_**stream.h    (working copy)
> @@ -20,7 +20,6 @@
>  class HttpResponseInfo;
>  class HttpRequestHeaders;
>  struct HttpRequestInfo;
> -class HttpStreamParser;
>  class IOBuffer;
>  class ProxyInfo;
>  struct SSLConfig;
> Index: net/http/http_proxy_client_**socket.h
> ==============================**==============================**=======
> --- net/http/http_proxy_client_**socket.h (revision 109476)
> +++ net/http/http_proxy_client_**socket.h (working copy)
> @@ -27,7 +27,6 @@
>  class ClientSocketHandle;
>  class GrowableIOBuffer;
>  class HttpAuthCache;
> -class HttpAuthHandleFactory;
>  class HttpStream;
>  class HttpStreamParser;
>  class IOBuffer;
> @@ -83,7 +82,9 @@
>
>   // Socket methods:
>   virtual int Read(IOBuffer* buf, int buf_len, OldCompletionCallback*
> callback);
> -  virtual int Write(IOBuffer* buf, int buf_len, OldCompletionCallback*
> callback);
> +  virtual int Write(IOBuffer* buf,
> +                    int buf_len,
> +                    OldCompletionCallback* callback);
>   virtual bool SetReceiveBufferSize(int32 size);
>   virtual bool SetSendBufferSize(int32 size);
>   virtual int GetPeerAddress(AddressList* address) const;
> Index: net/http/http_stream_factory.h
> ==============================**==============================**=======
> --- net/http/http_stream_factory.h      (revision 109476)
> +++ net/http/http_stream_factory.h      (working copy)
> @@ -24,15 +24,12 @@
>  class HostMappingRules;
>  class HostPortPair;
>  class HttpAuthController;
> -class HttpNetworkSession;
> -class HttpPipelinedHost;
>  class HttpResponseInfo;
>  class HttpServerProperties;
>  class HttpStream;
>  class ProxyInfo;
>  class SSLCertRequestInfo;
>  class SSLInfo;
> -class X509Certificate;
>  struct HttpRequestInfo;
>  struct SSLConfig;
>
> Index: net/http/http_stream_factory_**impl_job.h
> ==============================**==============================**=======
> --- net/http/http_stream_factory_**impl_job.h     (revision 109476)
> +++ net/http/http_stream_factory_**impl_job.h     (working copy)
> @@ -23,11 +23,7 @@
>  class ClientSocketHandle;
>  class HttpAuthController;
>  class HttpNetworkSession;
> -class HttpPipelinedConnection;
> -class HttpProxySocketParams;
>  class HttpStream;
> -class SOCKSSocketParams;
> -class SSLSocketParams;
>  class TransportSocketParams;
>
>  // An HttpStreamRequestImpl exists for each stream which is in progress
> of being
> Index: net/http/http_util.h
> ==============================**==============================**=======
> --- net/http/http_util.h        (revision 109476)
> +++ net/http/http_util.h        (working copy)
> @@ -21,8 +21,6 @@
>
>  namespace net {
>
> -class UploadDataStream;
> -
>  class NET_EXPORT HttpUtil {
>  public:
>   // Returns the absolute path of the URL, to be used for the http request.
> @@ -49,7 +47,7 @@
>   static void ParseContentType(const std::string& content_type_str,
>                                std::string* mime_type,
>                                std::string* charset,
> -                               bool *had_charset);
> +                               bool* had_charset);
>
>   // Scans the headers and look for the first "Range" header in |headers|,
>   // if "Range" exists and the first one of it is well formatted then
> returns
> Index: net/proxy/dhcp_proxy_script_**adapter_fetcher_win.h
> ==============================**==============================**=======
> --- net/proxy/dhcp_proxy_script_**adapter_fetcher_win.h   (revision
> 109476)
> +++ net/proxy/dhcp_proxy_script_**adapter_fetcher_win.h   (working copy)
> @@ -2,10 +2,12 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#ifndef NET_PROXY_DHCP_SCRIPT_ADAPTER_**FETCHER_WIN_H_
> -#define NET_PROXY_DHCP_SCRIPT_ADAPTER_**FETCHER_WIN_H_
> +#ifndef NET_PROXY_DHCP_PROXY_SCRIPT_**ADAPTER_FETCHER_WIN_H_
> +#define NET_PROXY_DHCP_PROXY_SCRIPT_**ADAPTER_FETCHER_WIN_H_
>  #pragma once
>
> +#include <string>
> +
>  #include "base/memory/ref_counted.h"
>  #include "base/memory/scoped_ptr.h"
>  #include "base/memory/weak_ptr.h"
> @@ -16,10 +18,6 @@
>  #include "net/base/net_export.h"
>  #include "googleurl/src/gurl.h"
>
> -namespace base {
> -class MessageLoopProxy;
> -}
> -
>  namespace net {
>
>  class ProxyScriptFetcher;
> @@ -180,4 +178,4 @@
>
>  }  // namespace net
>
> -#endif  // NET_PROXY_DHCP_SCRIPT_ADAPTER_**FETCHER_WIN_H_
> +#endif  // NET_PROXY_DHCP_PROXY_SCRIPT_**ADAPTER_FETCHER_WIN_H_
> Index: net/proxy/init_proxy_resolver.**h
> ==============================**==============================**=======
> --- net/proxy/init_proxy_resolver.**h     (revision 109476)
> +++ net/proxy/init_proxy_resolver.**h     (working copy)
> @@ -24,7 +24,6 @@
>  class ProxyConfig;
>  class ProxyResolver;
>  class ProxyScriptFetcher;
> -class URLRequestContext;
>
>  // InitProxyResolver is a helper class used by ProxyService to
>  // initialize a ProxyResolver with the PAC script data specified
> Index: net/proxy/proxy_script_**fetcher_impl.h
> ==============================**==============================**=======
> --- net/proxy/proxy_script_**fetcher_impl.h       (revision 109476)
> +++ net/proxy/proxy_script_**fetcher_impl.h       (working copy)
> @@ -6,6 +6,8 @@
>  #define NET_PROXY_PROXY_SCRIPT_**FETCHER_IMPL_H_
>  #pragma once
>
> +#include <string>
> +
>  #include "base/basictypes.h"
>  #include "base/compiler_specific.h"
>  #include "base/memory/ref_counted.h"
> @@ -17,7 +19,6 @@
>  #include "net/url_request/url_request.**h"
>
>  class GURL;
> -class X509Certificate;
>
>  namespace net {
>
> Index: net/proxy/proxy_service.h
> ==============================**==============================**=======
> --- net/proxy/proxy_service.h   (revision 109476)
> +++ net/proxy/proxy_service.h   (working copy)
> @@ -6,6 +6,7 @@
>  #define NET_PROXY_PROXY_SERVICE_H_
>  #pragma once
>
> +#include <string>
>  #include <vector>
>
>  #include "base/gtest_prod_util.h"
> @@ -33,7 +34,6 @@
>  class NetworkDelegate;
>  class ProxyResolver;
>  class ProxyScriptFetcher;
> -class URLRequestContext;
>
>  // This class can be used to resolve the proxy server to use when loading
> a
>  // HTTP(S) URL.  It uses the given ProxyResolver to handle the actual
> proxy
> Index: net/server/http_connection.h
> ==============================**==============================**=======
> --- net/server/http_connection.h        (revision 109476)
> +++ net/server/http_connection.h        (working copy)
> @@ -15,7 +15,6 @@
>  namespace net {
>
>  class HttpServer;
> -class HttpServerRequestInfo;
>  class ListenSocket;
>  class WebSocket;
>
> @@ -51,4 +50,4 @@
>
>  }  // namespace net
>
> -#endif // NET_SERVER_HTTP_CONNECTION_H_
> +#endif  // NET_SERVER_HTTP_CONNECTION_H_
> Index: net/socket/client_socket_**factory.h
> ==============================**==============================**=======
> --- net/socket/client_socket_**factory.h  (revision 109476)
> +++ net/socket/client_socket_**factory.h  (working copy)
> @@ -17,10 +17,8 @@
>  namespace net {
>
>  class AddressList;
> -class CertVerifier;
>  class ClientSocketHandle;
>  class DatagramClientSocket;
> -class DnsCertProvenanceChecker;
>  class HostPortPair;
>  class SSLClientSocket;
>  struct SSLClientSocketContext;
> Index: net/socket/ssl_client_socket_**pool.h
> ==============================**==============================**=======
> --- net/socket/ssl_client_socket_**pool.h (revision 109476)
> +++ net/socket/ssl_client_socket_**pool.h (working copy)
> @@ -36,7 +36,6 @@
>  class SSLHostInfoFactory;
>  class TransportSocketParams;
>  class TransportClientSocketPool;
> -struct RRResponse;
>
>  // SSLSocketParams only needs the socket params for the transport socket
>  // that will be used (denoted by |proxy|).
> Index: net/socket/ssl_server_socket.h
> ==============================**==============================**=======
> --- net/socket/ssl_server_socket.h      (revision 109476)
> +++ net/socket/ssl_server_socket.h      (working copy)
> @@ -20,7 +20,6 @@
>
>  namespace net {
>
> -class IOBuffer;
>  struct SSLConfig;
>  class X509Certificate;
>
> Index: net/spdy/spdy_proxy_client_**socket.h
> ==============================**==============================**=======
> --- net/spdy/spdy_proxy_client_**socket.h (revision 109476)
> +++ net/spdy/spdy_proxy_client_**socket.h (working copy)
> @@ -30,10 +30,8 @@
>  namespace net {
>
>  class AddressList;
> -class ClientSocketHandle;
>  class HttpStream;
>  class IOBuffer;
> -class SpdySession;
>  class SpdyStream;
>
>  class NET_EXPORT_PRIVATE SpdyProxyClientSocket : public ProxyClientSocket,
> @@ -82,7 +80,9 @@
>
>   // Socket methods:
>   virtual int Read(IOBuffer* buf, int buf_len, OldCompletionCallback*
> callback);
> -  virtual int Write(IOBuffer* buf, int buf_len, OldCompletionCallback*
> callback);
> +  virtual int Write(IOBuffer* buf,
> +                    int buf_len,
> +                    OldCompletionCallback* callback);
>   virtual bool SetReceiveBufferSize(int32 size);
>   virtual bool SetSendBufferSize(int32 size);
>   virtual int GetPeerAddress(AddressList* address) const;
> Index: net/spdy/spdy_session_pool.h
> ==============================**==============================**=======
> --- net/spdy/spdy_session_pool.h        (revision 109476)
> +++ net/spdy/spdy_session_pool.h        (working copy)
> @@ -31,7 +31,6 @@
>  class BoundNetLog;
>  class ClientSocketHandle;
>  class HostResolver;
> -class HttpNetworkSession;
>  class SpdySession;
>
>  // This is a very simple pool for open SpdySessions.
> Index: net/tools/flip_server/spdy_**interface.h
> ==============================**==============================**=======
> --- net/tools/flip_server/spdy_**interface.h      (revision 109476)
> +++ net/tools/flip_server/spdy_**interface.h      (working copy)
> @@ -2,8 +2,8 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#ifndef NET_TOOLS_FLIP_SERVER_SPDY_**INTERFACE_
> -#define NET_TOOLS_FLIP_SERVER_SPDY_**INTERFACE_
> +#ifndef NET_TOOLS_FLIP_SERVER_SPDY_**INTERFACE_H_
> +#define NET_TOOLS_FLIP_SERVER_SPDY_**INTERFACE_H_
>
>  #include <map>
>  #include <string>
> @@ -19,7 +19,6 @@
>
>  namespace net {
>
> -class BalsaFrame;
>  class FlipAcceptor;
>  class MemoryCache;
>
> @@ -57,8 +56,8 @@
>   SMInterface* FindOrMakeNewSMConnectionInter**face(std::string server_ip,
>                                                   std::string server_port);
>   int SpdyHandleNewStream(const spdy::SpdyControlFrame* frame,
> -                          std::string &http_data,
> -                          bool *is_https_scheme);
> +                          std::string& http_data,
> +                          bool* is_https_scheme);
>
>   // SpdyFramerVisitor interface.
>   virtual void OnControl(const spdy::SpdyControlFrame* frame);
> @@ -82,7 +81,7 @@
>   // SMInterface's Cleanup is currently only called by SMConnection after a
>   // protocol message as been fully read. Spdy's SMInterface does not need
>   // to do any cleanup at this time.
> -  // TODO (klindsay) This method is probably not being used properly and
> +  // TODO(klindsay) This method is probably not being used properly and
>   // some logic review and method renaming is probably in order.
>   virtual void Cleanup() {}
>   // Send a settings frame
> @@ -143,5 +142,4 @@
>
>  }  // namespace net
>
> -#endif  // NET_TOOLS_FLIP_SERVER_SPDY_**INTERFACE_
> -
> +#endif  // NET_TOOLS_FLIP_SERVER_SPDY_**INTERFACE_H_
> Index: net/url_request/url_request.h
> ==============================**==============================**=======
> --- net/url_request/url_request.h       (revision 109476)
> +++ net/url_request/url_request.h       (working copy)
> @@ -54,12 +54,6 @@
>
>  // Temporary layering violation to allow existing users of a deprecated
>  // interface.
> -namespace chrome_browser_net {
> -class ConnectInterceptor;
> -}
> -
> -// Temporary layering violation to allow existing users of a deprecated
> -// interface.
>  namespace fileapi {
>  class FileSystemDirURLRequestJobTest**;
>  class FileSystemOperationWriteTest;
> Index: net/url_request/url_request_**test_util.h
> ==============================**==============================**=======
> --- net/url_request/url_request_**test_util.h     (revision 109476)
> +++ net/url_request/url_request_**test_util.h     (working copy)
> @@ -8,7 +8,7 @@
>
>  #include <stdlib.h>
>
> -#include <sstream>
> +#include <map>
>  #include <string>
>
>  #include "base/compiler_specific.h"
> @@ -39,10 +39,6 @@
>
>  using base::TimeDelta;
>
> -namespace net {
> -class HostPortPair;
> -}
> -
>  //----------------------------**------------------------------**
> -------------------
>
>  class TestURLRequestContext : public net::URLRequestContext {
>
>
>

[commit-bot: I haz the power, 2011-11-11 05:14:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8525020/1

[commit-bot: I haz the power, 2011-11-11 05:14:54]

Can't process patch for file net/spdy/spdy_session_pool.h.
File's status is None, patchset upload is incomplete.