Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: net/base/network_delegate.h

Issue 8525020: Cleanup: Remove unneeded forward declararations in net. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/base/host_resolver.h ('k') | net/curvecp/messenger.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_BASE_NETWORK_DELEGATE_H_ 5 #ifndef NET_BASE_NETWORK_DELEGATE_H_
6 #define NET_BASE_NETWORK_DELEGATE_H_ 6 #define NET_BASE_NETWORK_DELEGATE_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/string16.h" 10 #include "base/string16.h"
11 #include "base/threading/non_thread_safe.h" 11 #include "base/threading/non_thread_safe.h"
12 #include "net/base/auth.h" 12 #include "net/base/auth.h"
13 #include "net/base/completion_callback.h" 13 #include "net/base/completion_callback.h"
14 14
15 class GURL; 15 class GURL;
16 16
17 namespace net { 17 namespace net {
18 18
19 // NOTE: Layering violations! 19 // NOTE: Layering violations!
20 // We decided to accept these violations (depending 20 // We decided to accept these violations (depending
21 // on other net/ submodules from net/base/), because otherwise NetworkDelegate 21 // on other net/ submodules from net/base/), because otherwise NetworkDelegate
22 // would have to be broken up into too many smaller interfaces targeted to each 22 // would have to be broken up into too many smaller interfaces targeted to each
23 // submodule. Also, since the lower levels in net/ may callback into higher 23 // submodule. Also, since the lower levels in net/ may callback into higher
24 // levels, we may encounter dangerous casting issues. 24 // levels, we may encounter dangerous casting issues.
25 // 25 //
26 // NOTE: It is not okay to add any compile-time dependencies on symbols outside 26 // NOTE: It is not okay to add any compile-time dependencies on symbols outside
27 // of net/base here, because we have a net_base library. Forward declarations 27 // of net/base here, because we have a net_base library. Forward declarations
28 // are ok. 28 // are ok.
29 class HostPortPair;
30 class HttpRequestHeaders; 29 class HttpRequestHeaders;
31 class HttpResponseHeaders; 30 class HttpResponseHeaders;
32 class URLRequest; 31 class URLRequest;
33 32
34 class NetworkDelegate : public base::NonThreadSafe { 33 class NetworkDelegate : public base::NonThreadSafe {
35 public: 34 public:
36 // AuthRequiredResponse indicates how a NetworkDelegate handles an 35 // AuthRequiredResponse indicates how a NetworkDelegate handles an
37 // OnAuthRequired call. It's placed in this file to prevent url_request.h 36 // OnAuthRequired call. It's placed in this file to prevent url_request.h
38 // from having to include network_delegate.h. 37 // from having to include network_delegate.h.
39 enum AuthRequiredResponse { 38 enum AuthRequiredResponse {
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 virtual AuthRequiredResponse OnAuthRequired( 158 virtual AuthRequiredResponse OnAuthRequired(
160 URLRequest* request, 159 URLRequest* request,
161 const AuthChallengeInfo& auth_info, 160 const AuthChallengeInfo& auth_info,
162 const AuthCallback& callback, 161 const AuthCallback& callback,
163 AuthCredentials* credentials) = 0; 162 AuthCredentials* credentials) = 0;
164 }; 163 };
165 164
166 } // namespace net 165 } // namespace net
167 166
168 #endif // NET_BASE_NETWORK_DELEGATE_H_ 167 #endif // NET_BASE_NETWORK_DELEGATE_H_
OLDNEW
« no previous file with comments | « net/base/host_resolver.h ('k') | net/curvecp/messenger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698