Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: vm/dart_api_impl.cc

Issue 8520030: Set the loaded_ flag in RawLibrary when it is completely loaded. This (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart_api_impl.cc
===================================================================
--- vm/dart_api_impl.cc (revision 1553)
+++ vm/dart_api_impl.cc (working copy)
@@ -399,6 +399,9 @@
source_str,
RawScript::kScript,
&result);
+ if (!Dart_IsError(result)) {
+ library.SetLoaded();
+ }
turnidge 2011/11/16 00:51:36 Does it make sense to move this into CompileSource
siva 2011/11/16 18:57:31 CompileSource is also called from Dart_LoadSource
return result;
}
@@ -518,6 +521,9 @@
source_str,
RawScript::kLibrary,
&result);
+ if (!Dart_IsError(result)) {
+ library.SetLoaded();
+ }
return result;
}
« no previous file with comments | « no previous file | vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698