Set the loaded_ flag in RawLibrary when it is completely loaded. This

vm/dart_api_impl.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 381 matching lines @@
   library = Library::New(url_str);
   library.Register();
   isolate->object_store()->set_root_library(library);
   Dart_Handle result;
   CompileSource(isolate,
                 library,
                 url_str,
                 source_str,
                 RawScript::kScript,
                 &result);
+  if (!Dart_IsError(result)) {
+    library.SetLoaded();
+  }

[turnidge, 2011/11/16 00:51:36]

Does it make sense to move this into CompileSource?

[siva, 2011/11/16 18:57:31]

CompileSource is also called from Dart_LoadSource and we 
it we set it inside CompileSoucce then we would be setting the flag prematurely.

On 2011/11/16 00:51:36, turnidge wrote:

   return result;
 }
 
 
 DEFINE_FLAG(bool, compile_all, false, "Eagerly compile all code.");
 
 static void CompileAll(Isolate* isolate, Dart_Handle* result) {
   *result = Api::Success();
   if (FLAG_compile_all) {
     ASSERT(isolate != NULL);
@@ skipping 99 matching lines @@
     library = Library::New(url_str);
     library.Register();
   }
   Dart_Handle result;
   CompileSource(isolate,
                 library,
                 url_str,
                 source_str,
                 RawScript::kLibrary,
                 &result);
+  if (!Dart_IsError(result)) {
+    library.SetLoaded();
+  }
   return result;
 }
 
 
 DART_EXPORT Dart_Handle Dart_LoadSource(Dart_Handle library_in,
                                         Dart_Handle url_in,
                                         Dart_Handle source_in) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const String& url = String::CheckedHandle(Api::UnwrapHandle(url_in));
@@ skipping 1602 matching lines @@
   ASSERT(isolate != NULL);
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
   ApiLocalScope* scope = state->top_scope();
   ASSERT(scope != NULL);
   return scope->zone().Reallocate(ptr, old_size, new_size);
 }
 
 
 }  // namespace dart