Updating the UMA metrics for profiles to make them more readable.

Updating the UMA metrics for profiles to make them more readable.

BUG=93825
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110414

[rpetterson, 2011-11-16 01:02:18]

isherman -- general metrics
miranda -- general profiles

There's really not a whole lot in this CL. Just a bunch of name changes.

[Miranda Callahan, 2011-11-16 01:14:00]

Profile-ish stuff LGTM with nit!

http://codereview.chromium.org/8520024/diff/5001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

http://codereview.chromium.org/8520024/diff/5001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:51: ADD_NEW_USER_MENU,    // User adds
new user from menu bar
nit: can you line all these up (and in the following enums), as in ProfileSync
below?

[rpetterson, 2011-11-16 01:21:21]

http://codereview.chromium.org/8520024/diff/5001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

http://codereview.chromium.org/8520024/diff/5001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:51: ADD_NEW_USER_MENU,    // User adds
new user from menu bar
On 2011/11/16 01:14:00, Miranda Callahan wrote:
> nit: can you line all these up (and in the following enums), as in ProfileSync
> below? 

Done.

[Ilya Sherman, 2011-11-16 03:29:19]

http://codereview.chromium.org/8520024/diff/1009/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.cc (right):

http://codereview.chromium.org/8520024/diff/1009/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.cc:126:
UMA_HISTOGRAM_ENUMERATION("Profile.OpenUser", metric,
nit: Perhaps "Profile.OpenMethod" rather than "Profile.OpenUser"?

http://codereview.chromium.org/8520024/diff/1009/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

http://codereview.chromium.org/8520024/diff/1009/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:84: SYNC_PASSPHRASE,          // User
is using a passphrase
Note that if you change the enum values, you should change the histogram name as
well.  Otherwise, you invalidate old data.  Another option in this case is to
declare """SYNC_CUSTOMIZE = 3""" with a comment explaining what happened to 0
through 2.

[rpetterson, 2011-11-16 22:46:25]

http://codereview.chromium.org/8520024/diff/1009/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.cc (right):

http://codereview.chromium.org/8520024/diff/1009/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.cc:126:
UMA_HISTOGRAM_ENUMERATION("Profile.OpenUser", metric,
On 2011/11/16 03:29:19, Ilya Sherman wrote:
> nit: Perhaps "Profile.OpenMethod" rather than "Profile.OpenUser"?

Done.

http://codereview.chromium.org/8520024/diff/1009/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

http://codereview.chromium.org/8520024/diff/1009/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:84: SYNC_PASSPHRASE,          // User
is using a passphrase
On 2011/11/16 03:29:19, Ilya Sherman wrote:
> Note that if you change the enum values, you should change the histogram name
as
> well.  Otherwise, you invalidate old data.  Another option in this case is to
> declare """SYNC_CUSTOMIZE = 3""" with a comment explaining what happened to 0
> through 2.

Fixed hte histogram name.

[Ilya Sherman, 2011-11-16 23:04:36]

LGTM with nit

http://codereview.chromium.org/8520024/diff/5005/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

http://codereview.chromium.org/8520024/diff/5005/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:60: SWITCH_PROFILE_MENU,      // User
switches profiles from menu bar
nit: I'd recommend keeping the relative order of ntp/icon the same for
bubble/switch.

[commit-bot: I haz the power, 2011-11-16 23:16:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlp@chromium.org/8520024/5005

[commit-bot: I haz the power, 2011-11-17 01:03:37]

Change committed as 110414