Updating the UMA metrics for profiles to make them more readable.

chrome/browser/profiles/profile_metrics.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_metrics.h"
 
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 19 matching lines @@
 }
 
 }  // namespace
 
 void ProfileMetrics::LogProfileAvatarSelection(size_t icon_index) {
   DCHECK(icon_index < NUM_PROFILE_AVATAR_METRICS);
   ProfileAvatar icon_name;
   switch (icon_index) {
     case 0:
       icon_name = AVATAR_GENERIC;
+      break;
     case 1:
       icon_name = AVATAR_GENERIC_AQUA;
+      break;
     case 2:
       icon_name = AVATAR_GENERIC_BLUE;
+      break;
     case 3:
       icon_name = AVATAR_GENERIC_GREEN;
+      break;
     case 4:
       icon_name = AVATAR_GENERIC_ORANGE;
+      break;
     case 5:
       icon_name = AVATAR_GENERIC_PURPLE;
+      break;
     case 6:
       icon_name = AVATAR_GENERIC_RED;
+      break;
     case 7:
       icon_name = AVATAR_GENERIC_YELLOW;
+      break;
     case 8:
       icon_name = AVATAR_SECRET_AGENT;
+      break;
     case 9:
       icon_name = AVATAR_SUPERHERO;
+      break;
     case 10:
       icon_name = AVATAR_VOLLEYBALL;
+      break;
     case 11:
       icon_name = AVATAR_BUSINESSMAN;
+      break;
     case 12:
       icon_name = AVATAR_NINJA;
+      break;
     case 13:
       icon_name = AVATAR_ALIEN;
+      break;
     case 14:
       icon_name = AVATAR_AWESOME;
+      break;
     case 15:
       icon_name = AVATAR_FLOWER;
+      break;
     case 16:
       icon_name = AVATAR_PIZZA;
+      break;
     case 17:
       icon_name = AVATAR_SOCCER;
+      break;
     case 18:
       icon_name = AVATAR_BURGER;
+      break;
     case 19:
       icon_name = AVATAR_CAT;
+      break;
     case 20:
       icon_name = AVATAR_CUPCAKE;
+      break;
     case 21:
       icon_name = AVATAR_DOG;
+      break;
     case 22:
       icon_name = AVATAR_HORSE;
+      break;
     case 23:
       icon_name = AVATAR_MARGARITA;
+      break;
     case 24:
       icon_name = AVATAR_NOTE;
+      break;
     case 25:
       icon_name = AVATAR_SUN_CLOUD;
+      break;
     default:  // We should never actually get here, but just in case
       icon_name = AVATAR_UNKNOWN;
+      break;
   }
   UMA_HISTOGRAM_ENUMERATION("Profile.Avatar", icon_name,
                             NUM_PROFILE_AVATAR_METRICS);
 }
 
 void ProfileMetrics::LogProfileOpenMethod(ProfileOpen metric) {
   DCHECK(metric < NUM_PROFILE_OPEN_METRICS);
-  UMA_HISTOGRAM_ENUMERATION("Profile.Opening", metric,
+  UMA_HISTOGRAM_ENUMERATION("Profile.OpenUser", metric,

[Ilya Sherman, 2011/11/16 03:29:19]

nit: Perhaps "Profile.OpenMethod" rather than "Profile.OpenUser"?

[rpetterson, 2011/11/16 22:46:25]

Done.

                             NUM_PROFILE_OPEN_METRICS);
 }
 
+void ProfileMetrics::LogProfileAddNewUser(ProfileAdd metric) {
+  DCHECK(metric < NUM_PROFILE_ADD_METRICS);
+  UMA_HISTOGRAM_ENUMERATION("Profile.AddNewUser", metric,
+                            NUM_PROFILE_ADD_METRICS);
+  UMA_HISTOGRAM_ENUMERATION("Profile.NetUserCount", ADD_NEW_USER,
+                            NUM_PROFILE_NET_METRICS);
+}
+
+void ProfileMetrics::LogProfileSwitchUser(ProfileSwitch metric) {
+  DCHECK(metric < NUM_PROFILE_SWITCH_METRICS);
+  UMA_HISTOGRAM_ENUMERATION("Profile.SwitchUser", metric,
+                            NUM_PROFILE_SWITCH_METRICS);
+}
+
+void ProfileMetrics::LogProfileDeleteUser(ProfileNetUserCounts metric) {
+  DCHECK(metric < NUM_PROFILE_NET_METRICS);
+  UMA_HISTOGRAM_ENUMERATION("Profile.NetUserCount", metric,
+                            NUM_PROFILE_NET_METRICS);
+}
+
 void ProfileMetrics::LogProfileSyncInfo(ProfileSync metric) {
   DCHECK(metric < NUM_PROFILE_SYNC_METRICS);
   UMA_HISTOGRAM_ENUMERATION("Profile.Sync", metric,
                             NUM_PROFILE_SYNC_METRICS);
 }
 
 void ProfileMetrics::LogProfileUpdate(FilePath& profile_path) {
   UMA_HISTOGRAM_ENUMERATION("Profile.Update",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }
 
 void ProfileMetrics::LogProfileSyncSignIn(FilePath& profile_path) {
-  ProfileSync metric = SYNC_SIGN_IN_ORIGINAL;
-  if (GetProfileType(profile_path) == SECONDARY) {
-    metric = SYNC_SIGN_IN_SECONDARY;
-  }
-  UMA_HISTOGRAM_ENUMERATION("Profile.Sync", SYNC_SIGN_IN,
-                            NUM_PROFILE_SYNC_METRICS);
-  UMA_HISTOGRAM_ENUMERATION("Profile.Sync", metric,
-                            NUM_PROFILE_SYNC_METRICS);
+  UMA_HISTOGRAM_ENUMERATION("Profile.SyncSignIn",
+                            GetProfileType(profile_path),
+                            NUM_PROFILE_TYPE_METRICS);
 }