Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 8520018: Add OVERRIDE to base/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, sadrul, brettw-cc_chromium.org
Visibility:
Public.

Description

Add OVERRIDE to base/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110218

Patch Set 1 #

Patch Set 2 : extra header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -96 lines) Patch
M base/file_descriptor_shuffle.h View 2 chunks +4 lines, -3 lines 0 comments Download
M base/file_version_info_mac.h View 1 chunk +16 lines, -16 lines 0 comments Download
M base/file_version_info_win.h View 1 chunk +16 lines, -16 lines 0 comments Download
M base/files/file_path_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_value_serializer.h View 4 chunks +6 lines, -4 lines 0 comments Download
M base/message_loop.h View 2 chunks +4 lines, -4 lines 0 comments Download
M base/message_loop_proxy_impl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M base/message_pump_default.h View 1 chunk +4 lines, -4 lines 0 comments Download
M base/message_pump_libevent.h View 2 chunks +5 lines, -4 lines 0 comments Download
M base/message_pump_mac.h View 4 chunks +11 lines, -11 lines 0 comments Download
M base/metrics/histogram.h View 5 chunks +10 lines, -9 lines 0 comments Download
M base/metrics/stats_counters.h View 2 chunks +2 lines, -1 line 0 comments Download
M base/process_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/waitable_event_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/task_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/perf_test_suite.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/signaling_task.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/simple_thread.h View 1 4 chunks +4 lines, -3 lines 0 comments Download
M base/threading/thread.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_collision_warner.h View 2 chunks +3 lines, -2 lines 0 comments Download
M base/threading/watchdog.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
9 years, 1 month ago (2011-11-15 19:53:52 UTC) #1
jam
On 2011/11/15 19:53:52, Avi wrote: probably want to send this to an owners of base? ...
9 years, 1 month ago (2011-11-15 21:35:15 UTC) #2
Avi (use Gerrit)
Was kinda looking for a rubber stamp. Will do though.
9 years, 1 month ago (2011-11-15 21:38:48 UTC) #3
Avi (use Gerrit)
9 years, 1 month ago (2011-11-15 21:39:35 UTC) #4
Mark Mentovai
Rubber-stamp LGTM once you receive a green try job, or just let the commit queue ...
9 years, 1 month ago (2011-11-15 21:48:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/8520018/1
9 years, 1 month ago (2011-11-15 21:50:38 UTC) #6
commit-bot: I haz the power
Try job failure for 8520018-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-15 22:09:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/8520018/3004
9 years, 1 month ago (2011-11-15 22:18:05 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 23:38:57 UTC) #9
Try job failure for 8520018-3004 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698