Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3551)

Unified Diff: base/metrics/histogram.h

Issue 8520018: Add OVERRIDE to base/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: extra header Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_pump_mac.h ('k') | base/metrics/stats_counters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram.h
diff --git a/base/metrics/histogram.h b/base/metrics/histogram.h
index 115c9d830a313b02eb34fc4445bfefc3482956f3..50cd90d32fc7be3ae181c48f275a3699b7d1e758 100644
--- a/base/metrics/histogram.h
+++ b/base/metrics/histogram.h
@@ -674,11 +674,12 @@ class BASE_EXPORT LinearHistogram : public Histogram {
Flags flags);
// Overridden from Histogram:
- virtual ClassType histogram_type() const;
+ virtual ClassType histogram_type() const OVERRIDE;
// Store a list of number/text values for use in rendering the histogram.
// The last element in the array has a null in its "description" slot.
- virtual void SetRangeDescriptions(const DescriptionPair descriptions[]);
+ virtual void SetRangeDescriptions(
+ const DescriptionPair descriptions[]) OVERRIDE;
protected:
LinearHistogram(const std::string& name, Sample minimum,
@@ -689,15 +690,15 @@ class BASE_EXPORT LinearHistogram : public Histogram {
// Initialize ranges_ mapping in cached_ranges_.
void InitializeBucketRange();
- virtual double GetBucketSize(Count current, size_t i) const;
+ virtual double GetBucketSize(Count current, size_t i) const OVERRIDE;
// If we have a description for a bucket, then return that. Otherwise
// let parent class provide a (numeric) description.
- virtual const std::string GetAsciiBucketRange(size_t i) const;
+ virtual const std::string GetAsciiBucketRange(size_t i) const OVERRIDE;
// Skip printing of name for numeric range if we have a name (and if this is
// an empty bucket).
- virtual bool PrintEmptyBucket(size_t index) const;
+ virtual bool PrintEmptyBucket(size_t index) const OVERRIDE;
private:
// For some ranges, we store a printable description of a bucket range.
@@ -716,9 +717,9 @@ class BASE_EXPORT BooleanHistogram : public LinearHistogram {
public:
static Histogram* FactoryGet(const std::string& name, Flags flags);
- virtual ClassType histogram_type() const;
+ virtual ClassType histogram_type() const OVERRIDE;
- virtual void AddBoolean(bool value);
+ virtual void AddBoolean(bool value) OVERRIDE;
private:
explicit BooleanHistogram(const std::string& name);
@@ -737,7 +738,7 @@ class BASE_EXPORT CustomHistogram : public Histogram {
Flags flags);
// Overridden from Histogram:
- virtual ClassType histogram_type() const;
+ virtual ClassType histogram_type() const OVERRIDE;
// Helper method for transforming an array of valid enumeration values
// to the std::vector<int> expected by HISTOGRAM_CUSTOM_ENUMERATION.
@@ -761,7 +762,7 @@ class BASE_EXPORT CustomHistogram : public Histogram {
// Initialize ranges_ mapping in cached_ranges_.
void InitializedCustomBucketRange(const std::vector<Sample>& custom_ranges);
- virtual double GetBucketSize(Count current, size_t i) const;
+ virtual double GetBucketSize(Count current, size_t i) const OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(CustomHistogram);
};
« no previous file with comments | « base/message_pump_mac.h ('k') | base/metrics/stats_counters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698